From d55e11eeb8ebf1e226a1166f395ba77248ce84c3 Mon Sep 17 00:00:00 2001 From: dsinclair Date: Tue, 12 Apr 2016 11:21:22 -0700 Subject: Remove ICodec_* Interfaces. All of the ICodec_* interfaces had a single implementation. This CL removes the interfaces and uses the concrete classes in their place. BUG=pdfium:468 Review URL: https://codereview.chromium.org/1876023003 --- core/fpdfapi/fpdf_render/fpdf_render_image.cpp | 2 +- core/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp | 16 ++++++++-------- core/fpdfapi/fpdf_render/render_int.h | 4 ++-- 3 files changed, 11 insertions(+), 11 deletions(-) (limited to 'core/fpdfapi/fpdf_render') diff --git a/core/fpdfapi/fpdf_render/fpdf_render_image.cpp b/core/fpdfapi/fpdf_render/fpdf_render_image.cpp index 55e97a9d81..ec8a784623 100644 --- a/core/fpdfapi/fpdf_render/fpdf_render_image.cpp +++ b/core/fpdfapi/fpdf_render/fpdf_render_image.cpp @@ -866,7 +866,7 @@ FX_BOOL CPDF_ImageRenderer::Continue(IFX_Pause* pPause) { } return FALSE; } -ICodec_ScanlineDecoder* FPDFAPI_CreateFlateDecoder( +CCodec_ScanlineDecoder* FPDFAPI_CreateFlateDecoder( const uint8_t* src_buf, uint32_t src_size, int width, diff --git a/core/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp b/core/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp index 7b88e84399..350c8b85d6 100644 --- a/core/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp +++ b/core/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp @@ -70,7 +70,7 @@ T ClampValue(T value, T max_value) { // Wrapper class to use with std::unique_ptr for CJPX_Decoder. class JpxBitMapContext { public: - explicit JpxBitMapContext(ICodec_JpxModule* jpx_module) + explicit JpxBitMapContext(CCodec_JpxModule* jpx_module) : jpx_module_(jpx_module), decoder_(nullptr) {} ~JpxBitMapContext() { jpx_module_->DestroyDecoder(decoder_); } @@ -81,7 +81,7 @@ class JpxBitMapContext { CJPX_Decoder* decoder() { return decoder_; } private: - ICodec_JpxModule* const jpx_module_; // Weak pointer. + CCodec_JpxModule* const jpx_module_; // Weak pointer. CJPX_Decoder* decoder_; // Decoder, owned. // Disallow evil constructors @@ -129,7 +129,7 @@ CPDF_DIBSource::~CPDF_DIBSource() { m_pDocument->GetPageData()->ReleaseColorSpace(pCS->GetArray()); } if (m_pJbig2Context) { - ICodec_Jbig2Module* pJbig2Module = CPDF_ModuleMgr::Get()->GetJbig2Module(); + CCodec_Jbig2Module* pJbig2Module = CPDF_ModuleMgr::Get()->GetJbig2Module(); pJbig2Module->DestroyJbig2Context(m_pJbig2Context); } } @@ -344,7 +344,7 @@ int CPDF_DIBSource::ContinueLoadDIBSource(IFX_Pause* pPause) { if (decoder == "JPXDecode") { return 0; } - ICodec_Jbig2Module* pJbig2Module = CPDF_ModuleMgr::Get()->GetJbig2Module(); + CCodec_Jbig2Module* pJbig2Module = CPDF_ModuleMgr::Get()->GetJbig2Module(); if (!m_pJbig2Context) { m_pJbig2Context = pJbig2Module->CreateJbig2Context(); if (m_pStreamAcc->GetImageParam()) { @@ -527,14 +527,14 @@ DIB_COMP_DATA* CPDF_DIBSource::GetDecodeAndMaskArray(FX_BOOL& bDefaultDecode, return pCompData; } -ICodec_ScanlineDecoder* FPDFAPI_CreateFaxDecoder( +CCodec_ScanlineDecoder* FPDFAPI_CreateFaxDecoder( const uint8_t* src_buf, uint32_t src_size, int width, int height, const CPDF_Dictionary* pParams); -ICodec_ScanlineDecoder* FPDFAPI_CreateFlateDecoder( +CCodec_ScanlineDecoder* FPDFAPI_CreateFlateDecoder( const uint8_t* src_buf, uint32_t src_size, int width, @@ -565,7 +565,7 @@ int CPDF_DIBSource::CreateDecoder() { FX_BOOL bTransform = FALSE; int comps; int bpc; - ICodec_JpegModule* pJpegModule = CPDF_ModuleMgr::Get()->GetJpegModule(); + CCodec_JpegModule* pJpegModule = CPDF_ModuleMgr::Get()->GetJpegModule(); if (pJpegModule->LoadInfo(src_data, src_size, m_Width, m_Height, comps, bpc, bTransform)) { if (m_nComponents != static_cast(comps)) { @@ -628,7 +628,7 @@ int CPDF_DIBSource::CreateDecoder() { } void CPDF_DIBSource::LoadJpxBitmap() { - ICodec_JpxModule* pJpxModule = CPDF_ModuleMgr::Get()->GetJpxModule(); + CCodec_JpxModule* pJpxModule = CPDF_ModuleMgr::Get()->GetJpxModule(); if (!pJpxModule) return; diff --git a/core/fpdfapi/fpdf_render/render_int.h b/core/fpdfapi/fpdf_render/render_int.h index eab6c9ff21..a94820ab8e 100644 --- a/core/fpdfapi/fpdf_render/render_int.h +++ b/core/fpdfapi/fpdf_render/render_int.h @@ -23,7 +23,7 @@ class CFX_GlyphBitmap; class CFX_ImageTransformer; class CPDF_ImageCacheEntry; class CPDF_ImageLoaderHandle; -class ICodec_ScanlineDecoder; +class CCodec_ScanlineDecoder; class CPDF_Type3Font; class CPDF_Type3Cache; class CPDF_Type3Char; @@ -605,7 +605,7 @@ class CPDF_DIBSource : public CFX_DIBSource { uint8_t* m_pLineBuf; uint8_t* m_pMaskedLine; std::unique_ptr m_pCachedBitmap; - std::unique_ptr m_pDecoder; + std::unique_ptr m_pDecoder; void* m_pJbig2Context; CPDF_DIBSource* m_pMask; std::unique_ptr m_pGlobalStream; -- cgit v1.2.3