From 833619b4441915c7c55085d44b3221eaef0d9800 Mon Sep 17 00:00:00 2001 From: tsepez Date: Wed, 7 Dec 2016 09:21:17 -0800 Subject: Refcount all the IFX_ stream classes all the time. We can remove a lot of "bOwnsStream" logic in the process. Always pass these by const reference, in case the called method wants to hang on to the stream (one exception is where we stick a raw pointer into a void* slot in a context from another layer). Review-Url: https://codereview.chromium.org/2451493002 --- core/fpdfapi/parser/cfdf_document.h | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) (limited to 'core/fpdfapi/parser/cfdf_document.h') diff --git a/core/fpdfapi/parser/cfdf_document.h b/core/fpdfapi/parser/cfdf_document.h index 1b47368458..f83adc1a30 100644 --- a/core/fpdfapi/parser/cfdf_document.h +++ b/core/fpdfapi/parser/cfdf_document.h @@ -18,9 +18,9 @@ class CPDF_Dictionary; class CFDF_Document : public CPDF_IndirectObjectHolder { public: static std::unique_ptr CreateNewDoc(); - static std::unique_ptr ParseFile(IFX_SeekableReadStream* pFile, - bool bOwnFile = false); - static std::unique_ptr ParseMemory(const uint8_t* pData, + static std::unique_ptr ParseFile( + const CFX_RetainPtr& pFile); + static std::unique_ptr ParseMemory(uint8_t* pData, uint32_t size); CFDF_Document(); @@ -30,11 +30,10 @@ class CFDF_Document : public CPDF_IndirectObjectHolder { CPDF_Dictionary* GetRoot() const { return m_pRootDict; } protected: - void ParseStream(IFX_SeekableReadStream* pFile, bool bOwnFile); + void ParseStream(const CFX_RetainPtr& pFile); CPDF_Dictionary* m_pRootDict; - IFX_SeekableReadStream* m_pFile; - bool m_bOwnFile; + CFX_RetainPtr m_pFile; }; #endif // CORE_FPDFAPI_PARSER_CFDF_DOCUMENT_H_ -- cgit v1.2.3