From d5bd8a16565bbee05bfb8a8409f3ba90c461da0e Mon Sep 17 00:00:00 2001 From: tsepez Date: Mon, 17 Oct 2016 11:13:54 -0700 Subject: Revert "Make CPDF_Object containers hold objects via unique pointers." This reverts commit 1d023881cd53485303c0fcc0b5878e700dc470fd. Reason for revert -- fuzzers hit issues. TBR=thestig@chromium.org Review-Url: https://codereview.chromium.org/2425783002 --- core/fpdfapi/parser/cpdf_data_avail.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'core/fpdfapi/parser/cpdf_data_avail.cpp') diff --git a/core/fpdfapi/parser/cpdf_data_avail.cpp b/core/fpdfapi/parser/cpdf_data_avail.cpp index 980c94d325..e23aa8ecfb 100644 --- a/core/fpdfapi/parser/cpdf_data_avail.cpp +++ b/core/fpdfapi/parser/cpdf_data_avail.cpp @@ -155,7 +155,7 @@ FX_BOOL CPDF_DataAvail::AreObjectsAvailable( for (const auto& it : *pDict) { const CFX_ByteString& key = it.first; - CPDF_Object* value = it.second.get(); + CPDF_Object* value = it.second; if (key != "Parent") new_obj_array.push_back(value); } @@ -493,8 +493,8 @@ FX_BOOL CPDF_DataAvail::CheckPage(DownloadHints* pHints) { CPDF_Array* pArray = ToArray(pObj); if (pArray) { - for (auto& pArrayObj : *pArray) { - if (CPDF_Reference* pRef = ToReference(pArrayObj.get())) + for (CPDF_Object* pArrayObj : *pArray) { + if (CPDF_Reference* pRef = ToReference(pArrayObj)) UnavailObjList.Add(pRef->GetRefObjNum()); } } @@ -742,7 +742,7 @@ FX_BOOL CPDF_DataAvail::CheckHintTables(DownloadHints* pHints) { return FALSE; } - for (const auto& pArrayObject : *pHintStreamRange) { + for (const CPDF_Object* pArrayObject : *pHintStreamRange) { const CPDF_Number* pNumber = ToNumber(pArrayObject->GetDirect()); if (!pNumber || !pNumber->IsInteger()) { m_docStatus = PDF_DATAAVAIL_ERROR; -- cgit v1.2.3