From 4de3d095c9d9e961f93750cf1ebd489fd515be12 Mon Sep 17 00:00:00 2001 From: tsepez Date: Thu, 3 Nov 2016 17:05:07 -0700 Subject: Remove CPDF_Object::Release() in favor of direct delete Follow-on once we prove Release always deletes in previous CL. Review-Url: https://codereview.chromium.org/2384883003 --- core/fpdfapi/parser/cpdf_dictionary.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'core/fpdfapi/parser/cpdf_dictionary.cpp') diff --git a/core/fpdfapi/parser/cpdf_dictionary.cpp b/core/fpdfapi/parser/cpdf_dictionary.cpp index 75cb1e859c..37efbbc34a 100644 --- a/core/fpdfapi/parser/cpdf_dictionary.cpp +++ b/core/fpdfapi/parser/cpdf_dictionary.cpp @@ -31,7 +31,7 @@ CPDF_Dictionary::~CPDF_Dictionary() { m_ObjNum = kInvalidObjNum; for (const auto& it : m_Map) { if (it.second && it.second->GetObjNum() != kInvalidObjNum) - it.second->Release(); + delete it.second; } } @@ -184,7 +184,7 @@ void CPDF_Dictionary::SetFor(const CFX_ByteString& key, CPDF_Object* pObj) { if (it->second == pObj) return; - it->second->Release(); + delete it->second; if (pObj) it->second = pObj; @@ -208,7 +208,7 @@ void CPDF_Dictionary::RemoveFor(const CFX_ByteString& key) { if (it == m_Map.end()) return; - it->second->Release(); + delete it->second; m_Map.erase(it); } @@ -223,7 +223,7 @@ void CPDF_Dictionary::ReplaceKey(const CFX_ByteString& oldkey, return; if (new_it != m_Map.end()) { - new_it->second->Release(); + delete new_it->second; new_it->second = old_it->second; } else { m_Map.insert(std::make_pair(MaybeIntern(newkey), old_it->second)); -- cgit v1.2.3