From 833619b4441915c7c55085d44b3221eaef0d9800 Mon Sep 17 00:00:00 2001 From: tsepez Date: Wed, 7 Dec 2016 09:21:17 -0800 Subject: Refcount all the IFX_ stream classes all the time. We can remove a lot of "bOwnsStream" logic in the process. Always pass these by const reference, in case the called method wants to hang on to the stream (one exception is where we stick a raw pointer into a void* slot in a context from another layer). Review-Url: https://codereview.chromium.org/2451493002 --- core/fpdfapi/parser/cpdf_stream.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'core/fpdfapi/parser/cpdf_stream.cpp') diff --git a/core/fpdfapi/parser/cpdf_stream.cpp b/core/fpdfapi/parser/cpdf_stream.cpp index de69bfae7b..4f76ec1c63 100644 --- a/core/fpdfapi/parser/cpdf_stream.cpp +++ b/core/fpdfapi/parser/cpdf_stream.cpp @@ -62,8 +62,9 @@ void CPDF_Stream::InitStream(const uint8_t* pData, m_pDict->SetNewFor("Length", static_cast(m_dwSize)); } -void CPDF_Stream::InitStreamFromFile(IFX_SeekableReadStream* pFile, - std::unique_ptr pDict) { +void CPDF_Stream::InitStreamFromFile( + const CFX_RetainPtr& pFile, + std::unique_ptr pDict) { m_pDict = std::move(pDict); m_bMemoryBased = false; m_pDataBuf.reset(); -- cgit v1.2.3