From d1a8458e6390103e123e9d265040b3d02c16955b Mon Sep 17 00:00:00 2001 From: Lei Zhang Date: Wed, 2 Aug 2017 17:41:22 -0700 Subject: Avoid a redundant header offset check in CPDF_Parser. CPDF_Parser::StartLinearizedParse() calls StartParse(), but already knows the PDF header offset. Refactor StartParse() so it does not have to look for the header again. Change-Id: Id8cc39301ae72da868dafc53921622d5b28ce26e Reviewed-on: https://pdfium-review.googlesource.com/9830 Commit-Queue: Lei Zhang Reviewed-by: Art Snake --- core/fpdfapi/parser/fpdf_parser_utility.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'core/fpdfapi/parser/fpdf_parser_utility.cpp') diff --git a/core/fpdfapi/parser/fpdf_parser_utility.cpp b/core/fpdfapi/parser/fpdf_parser_utility.cpp index 8323426e74..0c0ca6644f 100644 --- a/core/fpdfapi/parser/fpdf_parser_utility.cpp +++ b/core/fpdfapi/parser/fpdf_parser_utility.cpp @@ -75,12 +75,12 @@ int32_t GetHeaderOffset(const CFX_RetainPtr& pFile) { uint8_t buf[kBufSize]; for (int32_t offset = 0; offset <= 1024; ++offset) { if (!pFile->ReadBlock(buf, offset, kBufSize)) - return -1; + return kInvalidHeaderOffset; if (memcmp(buf, "%PDF", 4) == 0) return offset; } - return -1; + return kInvalidHeaderOffset; } int32_t GetDirectInteger(CPDF_Dictionary* pDict, const CFX_ByteString& key) { -- cgit v1.2.3