From 85c8e7f788512ce5b5b43cd816e8091b57c3d5e7 Mon Sep 17 00:00:00 2001 From: Dan Sinclair Date: Mon, 21 Nov 2016 13:50:32 -0500 Subject: Fixup lint flags. The -build/include setting was masking out build/include_what_you_use. This CL restores them, fixes any build errors, and adds NOLINT as needed. As well, the runtime/explicit and runtime/printf flags are aslo enabled and NOLINT'd. lint cleanups Change-Id: Ib013b3eb29c8d0e48cad74c5df9028684130719f Reviewed-on: https://pdfium-review.googlesource.com/2030 Reviewed-by: Tom Sepez --- core/fpdfapi/parser/cpdf_array.cpp | 1 + core/fpdfapi/parser/cpdf_array_unittest.cpp | 1 + core/fpdfapi/parser/cpdf_boolean.h | 2 ++ core/fpdfapi/parser/cpdf_data_avail.h | 2 ++ core/fpdfapi/parser/cpdf_document.h | 3 +++ core/fpdfapi/parser/cpdf_indirect_object_holder.cpp | 3 +++ core/fpdfapi/parser/cpdf_linearized_header.cpp | 3 +++ core/fpdfapi/parser/cpdf_name.h | 2 ++ core/fpdfapi/parser/cpdf_null.h | 2 ++ core/fpdfapi/parser/cpdf_number.h | 2 ++ core/fpdfapi/parser/cpdf_reference.h | 1 + core/fpdfapi/parser/cpdf_simple_parser.h | 2 +- 12 files changed, 23 insertions(+), 1 deletion(-) (limited to 'core/fpdfapi/parser') diff --git a/core/fpdfapi/parser/cpdf_array.cpp b/core/fpdfapi/parser/cpdf_array.cpp index 0973cb6bc6..64010e19e8 100644 --- a/core/fpdfapi/parser/cpdf_array.cpp +++ b/core/fpdfapi/parser/cpdf_array.cpp @@ -7,6 +7,7 @@ #include "core/fpdfapi/parser/cpdf_array.h" #include +#include #include "core/fpdfapi/parser/cpdf_name.h" #include "core/fpdfapi/parser/cpdf_number.h" diff --git a/core/fpdfapi/parser/cpdf_array_unittest.cpp b/core/fpdfapi/parser/cpdf_array_unittest.cpp index 866e961351..46777289b5 100644 --- a/core/fpdfapi/parser/cpdf_array_unittest.cpp +++ b/core/fpdfapi/parser/cpdf_array_unittest.cpp @@ -5,6 +5,7 @@ #include "core/fpdfapi/parser/cpdf_array.h" #include +#include #include "core/fpdfapi/parser/cpdf_number.h" #include "core/fpdfapi/parser/cpdf_reference.h" diff --git a/core/fpdfapi/parser/cpdf_boolean.h b/core/fpdfapi/parser/cpdf_boolean.h index 808f9ee6f0..afebc29448 100644 --- a/core/fpdfapi/parser/cpdf_boolean.h +++ b/core/fpdfapi/parser/cpdf_boolean.h @@ -7,6 +7,8 @@ #ifndef CORE_FPDFAPI_PARSER_CPDF_BOOLEAN_H_ #define CORE_FPDFAPI_PARSER_CPDF_BOOLEAN_H_ +#include + #include "core/fpdfapi/parser/cpdf_object.h" #include "core/fxcrt/fx_string.h" #include "core/fxcrt/fx_system.h" diff --git a/core/fpdfapi/parser/cpdf_data_avail.h b/core/fpdfapi/parser/cpdf_data_avail.h index 0f10ceb6fc..809b23fe59 100644 --- a/core/fpdfapi/parser/cpdf_data_avail.h +++ b/core/fpdfapi/parser/cpdf_data_avail.h @@ -7,6 +7,8 @@ #ifndef CORE_FPDFAPI_PARSER_CPDF_DATA_AVAIL_H_ #define CORE_FPDFAPI_PARSER_CPDF_DATA_AVAIL_H_ +#include +#include #include #include "core/fpdfapi/parser/cpdf_parser.h" diff --git a/core/fpdfapi/parser/cpdf_document.h b/core/fpdfapi/parser/cpdf_document.h index 1fd13a1c8e..59154d3ab3 100644 --- a/core/fpdfapi/parser/cpdf_document.h +++ b/core/fpdfapi/parser/cpdf_document.h @@ -9,6 +9,9 @@ #include #include +#include +#include +#include #include "core/fpdfapi/parser/cpdf_indirect_object_holder.h" #include "core/fpdfapi/parser/cpdf_object.h" diff --git a/core/fpdfapi/parser/cpdf_indirect_object_holder.cpp b/core/fpdfapi/parser/cpdf_indirect_object_holder.cpp index d1183ebaf4..efb9f84059 100644 --- a/core/fpdfapi/parser/cpdf_indirect_object_holder.cpp +++ b/core/fpdfapi/parser/cpdf_indirect_object_holder.cpp @@ -6,6 +6,9 @@ #include "core/fpdfapi/parser/cpdf_indirect_object_holder.h" +#include +#include + #include "core/fpdfapi/parser/cpdf_object.h" #include "core/fpdfapi/parser/cpdf_parser.h" diff --git a/core/fpdfapi/parser/cpdf_linearized_header.cpp b/core/fpdfapi/parser/cpdf_linearized_header.cpp index 9ecc051f8a..a56d64f259 100644 --- a/core/fpdfapi/parser/cpdf_linearized_header.cpp +++ b/core/fpdfapi/parser/cpdf_linearized_header.cpp @@ -6,6 +6,9 @@ #include "core/fpdfapi/parser/cpdf_linearized_header.h" +#include +#include + #include "core/fpdfapi/parser/cpdf_array.h" #include "core/fpdfapi/parser/cpdf_dictionary.h" #include "core/fpdfapi/parser/cpdf_number.h" diff --git a/core/fpdfapi/parser/cpdf_name.h b/core/fpdfapi/parser/cpdf_name.h index 6aac24ed88..61318d4afb 100644 --- a/core/fpdfapi/parser/cpdf_name.h +++ b/core/fpdfapi/parser/cpdf_name.h @@ -7,6 +7,8 @@ #ifndef CORE_FPDFAPI_PARSER_CPDF_NAME_H_ #define CORE_FPDFAPI_PARSER_CPDF_NAME_H_ +#include + #include "core/fpdfapi/parser/cpdf_object.h" #include "core/fxcrt/cfx_string_pool_template.h" #include "core/fxcrt/cfx_weak_ptr.h" diff --git a/core/fpdfapi/parser/cpdf_null.h b/core/fpdfapi/parser/cpdf_null.h index df985b92c0..4f8420f29d 100644 --- a/core/fpdfapi/parser/cpdf_null.h +++ b/core/fpdfapi/parser/cpdf_null.h @@ -7,6 +7,8 @@ #ifndef CORE_FPDFAPI_PARSER_CPDF_NULL_H_ #define CORE_FPDFAPI_PARSER_CPDF_NULL_H_ +#include + #include "core/fpdfapi/parser/cpdf_object.h" class CPDF_Null : public CPDF_Object { diff --git a/core/fpdfapi/parser/cpdf_number.h b/core/fpdfapi/parser/cpdf_number.h index 0a8f187244..85a78e5f1a 100644 --- a/core/fpdfapi/parser/cpdf_number.h +++ b/core/fpdfapi/parser/cpdf_number.h @@ -7,6 +7,8 @@ #ifndef CORE_FPDFAPI_PARSER_CPDF_NUMBER_H_ #define CORE_FPDFAPI_PARSER_CPDF_NUMBER_H_ +#include + #include "core/fpdfapi/parser/cpdf_object.h" #include "core/fxcrt/fx_string.h" #include "core/fxcrt/fx_system.h" diff --git a/core/fpdfapi/parser/cpdf_reference.h b/core/fpdfapi/parser/cpdf_reference.h index 93bab00334..5597142b95 100644 --- a/core/fpdfapi/parser/cpdf_reference.h +++ b/core/fpdfapi/parser/cpdf_reference.h @@ -7,6 +7,7 @@ #ifndef CORE_FPDFAPI_PARSER_CPDF_REFERENCE_H_ #define CORE_FPDFAPI_PARSER_CPDF_REFERENCE_H_ +#include #include #include "core/fpdfapi/parser/cpdf_object.h" diff --git a/core/fpdfapi/parser/cpdf_simple_parser.h b/core/fpdfapi/parser/cpdf_simple_parser.h index c638b8a04b..0ff6985660 100644 --- a/core/fpdfapi/parser/cpdf_simple_parser.h +++ b/core/fpdfapi/parser/cpdf_simple_parser.h @@ -13,7 +13,7 @@ class CPDF_SimpleParser { public: CPDF_SimpleParser(const uint8_t* pData, uint32_t dwSize); - CPDF_SimpleParser(const CFX_ByteStringC& str); + explicit CPDF_SimpleParser(const CFX_ByteStringC& str); CFX_ByteStringC GetWord(); -- cgit v1.2.3