From dce09b18b48837d8006694b9dc3b2d026e5e7869 Mon Sep 17 00:00:00 2001 From: Henrique Nakashima Date: Fri, 1 Sep 2017 12:14:26 -0400 Subject: Fix integer overflow in Buffer_itoa when passing INT_MIN. Bug: chromium:760034 Change-Id: Id0862749b1454e065de4de7d746a27e78ac58e30 Reviewed-on: https://pdfium-review.googlesource.com/12730 Commit-Queue: Henrique Nakashima Reviewed-by: Tom Sepez --- core/fpdfapi/parser/cpdf_number.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'core/fpdfapi/parser') diff --git a/core/fpdfapi/parser/cpdf_number.cpp b/core/fpdfapi/parser/cpdf_number.cpp index 50c48d6cb8..9afe30adca 100644 --- a/core/fpdfapi/parser/cpdf_number.cpp +++ b/core/fpdfapi/parser/cpdf_number.cpp @@ -53,7 +53,7 @@ void CPDF_Number::SetString(const CFX_ByteString& str) { } CFX_ByteString CPDF_Number::GetString() const { - return m_bInteger ? CFX_ByteString::FormatInteger(m_Integer, FXFORMAT_SIGNED) + return m_bInteger ? CFX_ByteString::FormatInteger(m_Integer) : CFX_ByteString::FormatFloat(m_Float); } -- cgit v1.2.3