From ee0fffe57e04041ba092a860418e5d4cfcbfd999 Mon Sep 17 00:00:00 2001 From: Ryan Harrison Date: Fri, 1 Jun 2018 19:44:53 +0000 Subject: Remove unused assignments in test code prev_offset is written multiple times through out CPDF_CrossRefAvailTest, but not read until it is written again. Removing this unused intermediate writes. Issues found with Clang Static Analyzer. Change-Id: I980263b8be7f691c030e937a05f248fd9b133fb4 Reviewed-on: https://pdfium-review.googlesource.com/33592 Commit-Queue: Ryan Harrison Reviewed-by: Henrique Nakashima --- core/fpdfapi/parser/cpdf_cross_ref_avail_unittest.cpp | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) (limited to 'core/fpdfapi/parser') diff --git a/core/fpdfapi/parser/cpdf_cross_ref_avail_unittest.cpp b/core/fpdfapi/parser/cpdf_cross_ref_avail_unittest.cpp index b798e17377..12b94ffb2d 100644 --- a/core/fpdfapi/parser/cpdf_cross_ref_avail_unittest.cpp +++ b/core/fpdfapi/parser/cpdf_cross_ref_avail_unittest.cpp @@ -136,10 +136,8 @@ TEST(CPDF_CrossRefAvailTest, IncorrectData) { TEST(CPDF_CrossRefAvailTest, ThreeCrossRefV4) { char int_buffer[100]; - int prev_offset = 0; int cur_offset = 0; std::string table = "pdf blah blah blah\n"; - prev_offset = cur_offset; cur_offset = static_cast(table.size()); table += "xref \n" @@ -150,7 +148,7 @@ TEST(CPDF_CrossRefAvailTest, ThreeCrossRefV4) { "[<4f9bb2e7978401808f8f1f2a75c322c8>]" "/Info 15 0 R/Size 16>>\n"; table += "Dummy Data jgwhughouiwbahng"; - prev_offset = cur_offset; + int prev_offset = cur_offset; cur_offset = static_cast(table.size()); table += std::string( "xref \n" @@ -188,10 +186,8 @@ TEST(CPDF_CrossRefAvailTest, ThreeCrossRefV4) { TEST(CPDF_CrossRefAvailTest, ThreeCrossRefV5) { char int_buffer[100]; - int prev_offset = 0; int cur_offset = 0; std::string table = "pdf blah blah blah\n"; - prev_offset = cur_offset; cur_offset = static_cast(table.size()); table += "16 0 obj\n" @@ -202,7 +198,7 @@ TEST(CPDF_CrossRefAvailTest, ThreeCrossRefV5) { "endobj\n"; table += "Dummy Data jgwhughouiwbahng"; - prev_offset = cur_offset; + int prev_offset = cur_offset; cur_offset = static_cast(table.size()); table += std::string( "55 0 obj\n" -- cgit v1.2.3