From 98d1b48e9a3471a02968f3d12692645fa0fcb50d Mon Sep 17 00:00:00 2001 From: Lei Zhang Date: Wed, 24 Oct 2018 23:53:03 +0000 Subject: Clean up CFX_ImageTransformer parameters. - A valid matrix is always passed in, so make the parameter const-ref. Since it is not obvious who owns the passed in matrix, make a copy with the corresponding matrix member. - Since the matrix parameter is const-ref, CFX_DIBBase::TransformTo() can also have a const-ref matrix parameter. - |flags| should be uint32_t, since |m_Flags| is. - |pClips| is only used inside the ctor, so remove |m_pClip|. Change-Id: If3d58a3fd28fa72b4ac7caac15f49a8057c594db Reviewed-on: https://pdfium-review.googlesource.com/c/44541 Reviewed-by: Tom Sepez Commit-Queue: Lei Zhang --- core/fpdfapi/render/cpdf_imagerenderer.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'core/fpdfapi/render/cpdf_imagerenderer.cpp') diff --git a/core/fpdfapi/render/cpdf_imagerenderer.cpp b/core/fpdfapi/render/cpdf_imagerenderer.cpp index da63f556a7..362cf558f7 100644 --- a/core/fpdfapi/render/cpdf_imagerenderer.cpp +++ b/core/fpdfapi/render/cpdf_imagerenderer.cpp @@ -416,7 +416,7 @@ bool CPDF_ImageRenderer::StartDIBBase() { clip_box.Intersect(image_rect); m_Status = 2; m_pTransformer = pdfium::MakeUnique( - m_pDIBBase, &m_ImageMatrix, m_Flags, &clip_box); + m_pDIBBase, m_ImageMatrix, m_Flags, &clip_box); return true; } if (m_ImageMatrix.a < 0) @@ -485,7 +485,7 @@ bool CPDF_ImageRenderer::StartBitmapAlpha() { int left; int top; RetainPtr pTransformed = - pAlphaMask->TransformTo(&m_ImageMatrix, &left, &top); + pAlphaMask->TransformTo(m_ImageMatrix, &left, &top); if (!pTransformed) return true; -- cgit v1.2.3