From 4dd613cb51c1d77ac2998f760325ed5b93f4ebf0 Mon Sep 17 00:00:00 2001 From: kcwu Date: Fri, 23 Sep 2016 09:26:51 -0700 Subject: Bail out on bad width and height in CCodec_FaxDecoder::CreateDecoder BUG=648935,649436 Review-Url: https://codereview.chromium.org/2360283004 --- core/fpdfapi/fpdf_parser/fpdf_parser_decode.cpp | 3 --- 1 file changed, 3 deletions(-) (limited to 'core/fpdfapi') diff --git a/core/fpdfapi/fpdf_parser/fpdf_parser_decode.cpp b/core/fpdfapi/fpdf_parser/fpdf_parser_decode.cpp index 72a9518ca9..1b5bd024f8 100644 --- a/core/fpdfapi/fpdf_parser/fpdf_parser_decode.cpp +++ b/core/fpdfapi/fpdf_parser/fpdf_parser_decode.cpp @@ -248,9 +248,6 @@ CCodec_ScanlineDecoder* FPDFAPI_CreateFaxDecoder( if (Rows > USHRT_MAX) { Rows = 0; } - if (Columns <= 0 || Rows < 0 || Columns > USHRT_MAX || Rows > USHRT_MAX) { - return nullptr; - } } return CPDF_ModuleMgr::Get()->GetFaxModule()->CreateDecoder( src_buf, src_size, width, height, K, EndOfLine, ByteAlign, BlackIs1, -- cgit v1.2.3