From afd0d1f488ea55da545b3310fd8f22e45522a695 Mon Sep 17 00:00:00 2001 From: Tom Sepez Date: Tue, 4 Apr 2017 14:37:18 -0700 Subject: RefCount CPDF_StreamAcc all the time. Pass stream argument to constructor; it feels like a stream accessor should always be made from a stream rather than passing one in after the fact. Change-Id: Iaa46cb37677b81f0170f5d39bab76ad38ea4af44 Reviewed-on: https://pdfium-review.googlesource.com/3620 Commit-Queue: Tom Sepez Reviewed-by: Lei Zhang --- core/fpdfdoc/cpdf_metadata.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'core/fpdfdoc/cpdf_metadata.cpp') diff --git a/core/fpdfdoc/cpdf_metadata.cpp b/core/fpdfdoc/cpdf_metadata.cpp index 3780d1587d..5379275544 100644 --- a/core/fpdfdoc/cpdf_metadata.cpp +++ b/core/fpdfdoc/cpdf_metadata.cpp @@ -20,9 +20,9 @@ CPDF_Metadata::CPDF_Metadata(CPDF_Document* pDoc) { if (!pStream) return; - CPDF_StreamAcc acc; - acc.LoadAllData(pStream, false); - m_pXmlElement = CXML_Element::Parse(acc.GetData(), acc.GetSize()); + auto pAcc = pdfium::MakeRetain(pStream); + pAcc->LoadAllData(false); + m_pXmlElement = CXML_Element::Parse(pAcc->GetData(), pAcc->GetSize()); } CPDF_Metadata::~CPDF_Metadata() {} -- cgit v1.2.3