From bb47f9a442b5ea2196f18cb2df3cedd34b81b9ad Mon Sep 17 00:00:00 2001 From: dsinclair Date: Mon, 23 Apr 2018 18:35:17 +0000 Subject: Revert "Change CFX_XML Save to take a write stream" This reverts commit 9a3a7709103a872037dcea1f3cf0b7785a3da191. Reason for revert: Gerrit did not do what I expected.... Original change's description: > Change CFX_XML Save to take a write stream > > This CL changes CFX_XML to use an IFX_SeekableWriteStream instead of the more > generic IFX_SeekableStream. > > Change-Id: I6e4def380c43eca755d91ad5cb6146c2dfdaee10 > Reviewed-on: https://pdfium-review.googlesource.com/30877 > Commit-Queue: dsinclair > Reviewed-by: Tom Sepez TBR=tsepez@chromium.org,dsinclair@chromium.org,hnakashima@chromium.org Change-Id: I137e53bf93285b88ade6832dedefca66e3b61e13 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://pdfium-review.googlesource.com/31211 Reviewed-by: dsinclair Commit-Queue: dsinclair --- core/fpdfdoc/cpdf_metadata.cpp | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) (limited to 'core/fpdfdoc/cpdf_metadata.cpp') diff --git a/core/fpdfdoc/cpdf_metadata.cpp b/core/fpdfdoc/cpdf_metadata.cpp index c928952dca..161fc93edd 100644 --- a/core/fpdfdoc/cpdf_metadata.cpp +++ b/core/fpdfdoc/cpdf_metadata.cpp @@ -19,11 +19,12 @@ void CheckForSharedFormInternal(CFX_XMLElement* element, std::vector* unsupported) { WideString attr = element->GetAttribute(L"xmlns:adhocwf"); if (attr == L"http://ns.adobe.com/AcrobatAdhocWorkflow/1.0/") { - for (const auto& child : *element) { + for (const auto* child = element->GetFirstChild(); child; + child = child->GetNextSibling()) { if (child->GetType() != FX_XMLNODE_Element) continue; - const auto* child_elem = static_cast(child.get()); + const auto* child_elem = static_cast(child); if (child_elem->GetName() != L"adhocwf:workflowType") continue; @@ -45,11 +46,12 @@ void CheckForSharedFormInternal(CFX_XMLElement* element, } } - for (const auto& child : *element) { + for (auto* child = element->GetFirstChild(); child; + child = child->GetNextSibling()) { if (child->GetType() != FX_XMLNODE_Element) continue; - CheckForSharedFormInternal(static_cast(child.get()), + CheckForSharedFormInternal(static_cast(child), unsupported); } } -- cgit v1.2.3