From 9c292fef316739f43730f11b9a2b6d3e4b725b54 Mon Sep 17 00:00:00 2001 From: Tom Sepez Date: Thu, 21 Jun 2018 15:02:24 +0000 Subject: Avoid const-refs to implicitly constructed strings. Because the invisible temporary goes out of scope at the next semicolon. Also avoid returning const string references since the cost is low to properly keep the string alive. Change-Id: Id283e4fd99f79a02d79d739a533a4ce05e831e2a Reviewed-on: https://pdfium-review.googlesource.com/35710 Commit-Queue: dsinclair Reviewed-by: dsinclair --- core/fpdfdoc/cpdf_structelement.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'core/fpdfdoc/cpdf_structelement.h') diff --git a/core/fpdfdoc/cpdf_structelement.h b/core/fpdfdoc/cpdf_structelement.h index 4e590cb879..79e8dd92c8 100644 --- a/core/fpdfdoc/cpdf_structelement.h +++ b/core/fpdfdoc/cpdf_structelement.h @@ -39,8 +39,8 @@ class CPDF_StructElement : public Retainable { template friend RetainPtr pdfium::MakeRetain(Args&&... args); - const ByteString& GetType() const { return m_Type; } - const ByteString& GetTitle() const { return m_Title; } + ByteString GetType() const { return m_Type; } + ByteString GetTitle() const { return m_Title; } const CPDF_Dictionary* GetDict() const { return m_pDict.Get(); } size_t CountKids() const; -- cgit v1.2.3