From a9caab94c1f16929e5acf2676117224617d80f53 Mon Sep 17 00:00:00 2001 From: tsepez Date: Wed, 14 Dec 2016 05:57:10 -0800 Subject: Avoid the ptr.reset(new XXX()) anti-pattern Be suspicious of |new|. This removes some of the easy cases. Review-Url: https://codereview.chromium.org/2571913002 --- core/fpdfdoc/cpvt_wordinfo.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'core/fpdfdoc/cpvt_wordinfo.cpp') diff --git a/core/fpdfdoc/cpvt_wordinfo.cpp b/core/fpdfdoc/cpvt_wordinfo.cpp index 2303f30032..f1ea11915c 100644 --- a/core/fpdfdoc/cpvt_wordinfo.cpp +++ b/core/fpdfdoc/cpvt_wordinfo.cpp @@ -5,6 +5,7 @@ // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com #include "core/fpdfdoc/cpvt_wordinfo.h" +#include "third_party/base/ptr_util.h" CPVT_WordInfo::CPVT_WordInfo() : Word(0), @@ -48,7 +49,7 @@ void CPVT_WordInfo::operator=(const CPVT_WordInfo& word) { fWordY = word.fWordY; fWordTail = word.fWordTail; if (word.pWordProps) - pWordProps.reset(new CPVT_WordProps(*word.pWordProps)); + pWordProps = pdfium::MakeUnique(*word.pWordProps); else pWordProps.reset(); } -- cgit v1.2.3