From 2c3a16a7698ba15476173e849f82c97ea3da9939 Mon Sep 17 00:00:00 2001 From: thestig Date: Tue, 10 May 2016 13:24:16 -0700 Subject: Remove some dead code. - No caller checks the CPDF_VariableText::SetProvider() return value. - IFX_Edit::SetVTProvider() is unused. - CFX_ListItem::SetCaret() is useless. - CFX_List::SetItemCaret() is also useless. - CPVT_GenerateAP::GenerateEditAP() has a param that's always NULL. Review-Url: https://codereview.chromium.org/1960183003 --- core/fpdfdoc/include/cpdf_variabletext.h | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) (limited to 'core/fpdfdoc/include') diff --git a/core/fpdfdoc/include/cpdf_variabletext.h b/core/fpdfdoc/include/cpdf_variabletext.h index b73d3df8c1..a14ad52752 100644 --- a/core/fpdfdoc/include/cpdf_variabletext.h +++ b/core/fpdfdoc/include/cpdf_variabletext.h @@ -24,8 +24,8 @@ struct CPVT_SecProps; struct CPVT_Section; struct CPVT_SectionInfo; struct CPVT_Word; -struct CPVT_WordProps; struct CPVT_WordInfo; +struct CPVT_WordProps; #define VARIABLETEXT_HALF 0.5f @@ -60,7 +60,7 @@ class CPDF_VariableText : private CPDF_EditContainer { class Provider { public: - Provider(IPVT_FontMap* pFontMap); + explicit Provider(IPVT_FontMap* pFontMap); virtual ~Provider(); virtual int32_t GetCharWidth(int32_t nFontIndex, @@ -79,10 +79,9 @@ class CPDF_VariableText : private CPDF_EditContainer { }; CPDF_VariableText(); - virtual ~CPDF_VariableText(); + ~CPDF_VariableText() override; - CPDF_VariableText::Provider* SetProvider( - CPDF_VariableText::Provider* pProvider); + void SetProvider(CPDF_VariableText::Provider* pProvider); CPDF_VariableText::Iterator* GetIterator(); // CPDF_EditContainer. -- cgit v1.2.3