From 0186c1817bd1503051597dbcf0b032d4ff1277ab Mon Sep 17 00:00:00 2001 From: Ryan Harrison Date: Tue, 1 Aug 2017 16:20:40 -0400 Subject: Remove support for negative params to ReleaseBuffer() This CL removes the default param value for this method, which was negative. It also adds in a method to get buffer lengths, so that the callsites can explictly passing in the length of the buffer if they were using the default value previously. BUG=pdfium:828 Change-Id: I0170771ee81970b8b601631015ab3e6e39fea8ea Reviewed-on: https://pdfium-review.googlesource.com/9790 Reviewed-by: Tom Sepez Commit-Queue: Ryan Harrison --- core/fpdftext/cpdf_textpagefind.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'core/fpdftext') diff --git a/core/fpdftext/cpdf_textpagefind.cpp b/core/fpdftext/cpdf_textpagefind.cpp index adef9f6c0c..3c8e532a7f 100644 --- a/core/fpdftext/cpdf_textpagefind.cpp +++ b/core/fpdftext/cpdf_textpagefind.cpp @@ -377,7 +377,7 @@ bool CPDF_TextPageFind::ExtractSubString(CFX_WideString& rString, : (int)FXSYS_wcslen(lpszFullString); ASSERT(nLen >= 0); memcpy(rString.GetBuffer(nLen), lpszFullString, nLen * sizeof(wchar_t)); - rString.ReleaseBuffer(); + rString.ReleaseBuffer(rString.GetStringLength()); return true; } -- cgit v1.2.3