From ef73cf5838ab3a902872d9fc57a90621cc3d7f21 Mon Sep 17 00:00:00 2001 From: Nicolas Pena Date: Fri, 12 May 2017 14:36:06 -0400 Subject: Rename ErrorData and fix potential leak MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This CL fixes a leak that can be caused by a longjmp in ErrorData. The method is renamed to express the fact that it includes such, and a followup should remove the jmps altogether. Bug: chromium:721488 Change-Id: Iefcc82a77a30ff77b7973b05611440a8d5bf275e Reviewed-on: https://pdfium-review.googlesource.com/5450 Commit-Queue: Nicolás Peña Reviewed-by: Tom Sepez --- core/fxcodec/codec/fx_codec_progress.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'core/fxcodec/codec/fx_codec_progress.cpp') diff --git a/core/fxcodec/codec/fx_codec_progress.cpp b/core/fxcodec/codec/fx_codec_progress.cpp index aa97ac4bb2..4cbae5cc75 100644 --- a/core/fxcodec/codec/fx_codec_progress.cpp +++ b/core/fxcodec/codec/fx_codec_progress.cpp @@ -1804,8 +1804,7 @@ FXCODEC_STATUS CCodec_ProgressiveDecoder::GetFrames(int32_t& frames) { m_status = FXCODEC_STATUS_DECODE_READY; return m_status; } - if (m_pGifContext.get()) - m_pGifContext = nullptr; + m_pGifContext = nullptr; m_status = FXCODEC_STATUS_ERROR; return m_status; } -- cgit v1.2.3