From ef73cf5838ab3a902872d9fc57a90621cc3d7f21 Mon Sep 17 00:00:00 2001 From: Nicolas Pena Date: Fri, 12 May 2017 14:36:06 -0400 Subject: Rename ErrorData and fix potential leak MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This CL fixes a leak that can be caused by a longjmp in ErrorData. The method is renamed to express the fact that it includes such, and a followup should remove the jmps altogether. Bug: chromium:721488 Change-Id: Iefcc82a77a30ff77b7973b05611440a8d5bf275e Reviewed-on: https://pdfium-review.googlesource.com/5450 Commit-Queue: Nicolás Peña Reviewed-by: Tom Sepez --- core/fxcodec/lgif/cgifcontext.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'core/fxcodec/lgif/cgifcontext.h') diff --git a/core/fxcodec/lgif/cgifcontext.h b/core/fxcodec/lgif/cgifcontext.h index 2ee8fbe396..e65d6c7b0b 100644 --- a/core/fxcodec/lgif/cgifcontext.h +++ b/core/fxcodec/lgif/cgifcontext.h @@ -21,7 +21,8 @@ class CGifContext { CGifContext(CCodec_GifModule* gif_module, char* error_string); ~CGifContext(); - void ErrorData(const char* err_msg); + // TODO(npm): Remove longjmp from this method!!! + void ThrowError(const char* err_msg); void RecordCurrentPosition(uint32_t* cur_pos_ptr); void ReadScanline(int32_t row_num, uint8_t* row_buf); bool GetRecordPosition(uint32_t cur_pos, -- cgit v1.2.3