From 214982c4d02a720c3b1b3de121cddc62189b8848 Mon Sep 17 00:00:00 2001 From: Lei Zhang Date: Fri, 21 Sep 2018 15:35:42 +0000 Subject: Remove unreachable code in CPDF_DIBBase. The colorspace is always available when creating image decoders that use colorspaces. Change-Id: I20ac75edcd614ccc1e83de262c128776e9d03eed Reviewed-on: https://pdfium-review.googlesource.com/42872 Commit-Queue: Ryan Harrison Reviewed-by: Ryan Harrison --- core/fxcodec/codec/ccodec_jpxmodule.cpp | 2 ++ 1 file changed, 2 insertions(+) (limited to 'core/fxcodec') diff --git a/core/fxcodec/codec/ccodec_jpxmodule.cpp b/core/fxcodec/codec/ccodec_jpxmodule.cpp index 28221be340..2465ea7bd0 100644 --- a/core/fxcodec/codec/ccodec_jpxmodule.cpp +++ b/core/fxcodec/codec/ccodec_jpxmodule.cpp @@ -646,6 +646,8 @@ CCodec_JpxModule::~CCodec_JpxModule() {} std::unique_ptr CCodec_JpxModule::CreateDecoder( pdfium::span src_span, CPDF_ColorSpace* cs) { + // TODO(thestig): |cs| should never be nullptr in production, but + // pdf_jpx_fuzzer.cc passes that in. auto decoder = pdfium::MakeUnique(cs); if (!decoder->Init(src_span)) return nullptr; -- cgit v1.2.3