From 55865454c43fbc3b163cff166544ba0a060dcbc4 Mon Sep 17 00:00:00 2001 From: Tom Sepez Date: Mon, 27 Aug 2018 20:18:04 +0000 Subject: The final game: mark everything final. Then revert the ones that break compilation. Fix one IWYU noticed during presubmit. Change-Id: I881a8a72818e55dbc4816247e35ff5e3015194e7 Reviewed-on: https://pdfium-review.googlesource.com/41470 Reviewed-by: Lei Zhang Commit-Queue: Tom Sepez --- core/fxcodec/bmp/cfx_bmpcontext.h | 2 +- core/fxcodec/codec/ccodec_pngmodule.cpp | 2 +- core/fxcodec/codec/ccodec_tiffmodule.cpp | 2 +- core/fxcodec/codec/cfx_codec_memory.h | 2 +- core/fxcodec/codec/fx_codec.cpp | 2 +- core/fxcodec/codec/fx_codec_fax.cpp | 2 +- core/fxcodec/codec/fx_codec_flate.cpp | 2 +- core/fxcodec/codec/fx_codec_jpeg.cpp | 4 ++-- core/fxcodec/gif/cfx_gifcontext_unittest.cpp | 2 +- 9 files changed, 10 insertions(+), 10 deletions(-) (limited to 'core/fxcodec') diff --git a/core/fxcodec/bmp/cfx_bmpcontext.h b/core/fxcodec/bmp/cfx_bmpcontext.h index 198d080fb8..89e6463872 100644 --- a/core/fxcodec/bmp/cfx_bmpcontext.h +++ b/core/fxcodec/bmp/cfx_bmpcontext.h @@ -10,7 +10,7 @@ #include "core/fxcodec/bmp/cfx_bmpdecompressor.h" #include "core/fxcodec/bmp/fx_bmp.h" -class CFX_BmpContext : public CCodec_BmpModule::Context { +class CFX_BmpContext final : public CCodec_BmpModule::Context { public: CFX_BmpContext(CCodec_BmpModule* pModule, CCodec_BmpModule::Delegate* pDelegate); diff --git a/core/fxcodec/codec/ccodec_pngmodule.cpp b/core/fxcodec/codec/ccodec_pngmodule.cpp index 98db4e272e..2c22f6bdba 100644 --- a/core/fxcodec/codec/ccodec_pngmodule.cpp +++ b/core/fxcodec/codec/ccodec_pngmodule.cpp @@ -23,7 +23,7 @@ #define PNG_ERROR_SIZE 256 -class CPngContext : public CCodec_PngModule::Context { +class CPngContext final : public CCodec_PngModule::Context { public: CPngContext(CCodec_PngModule* pModule, CCodec_PngModule::Delegate* pDelegate); ~CPngContext() override; diff --git a/core/fxcodec/codec/ccodec_tiffmodule.cpp b/core/fxcodec/codec/ccodec_tiffmodule.cpp index 5f74b28cdc..78f631cba9 100644 --- a/core/fxcodec/codec/ccodec_tiffmodule.cpp +++ b/core/fxcodec/codec/ccodec_tiffmodule.cpp @@ -32,7 +32,7 @@ struct TiffDeleter { } // namespace -class CTiffContext : public CCodec_TiffModule::Context { +class CTiffContext final : public CCodec_TiffModule::Context { public: CTiffContext() = default; ~CTiffContext() override = default; diff --git a/core/fxcodec/codec/cfx_codec_memory.h b/core/fxcodec/codec/cfx_codec_memory.h index e726dc5320..2907e892d2 100644 --- a/core/fxcodec/codec/cfx_codec_memory.h +++ b/core/fxcodec/codec/cfx_codec_memory.h @@ -8,7 +8,7 @@ #include "core/fxcrt/retain_ptr.h" #include "third_party/base/span.h" -class CFX_CodecMemory : public Retainable { +class CFX_CodecMemory final : public Retainable { public: template friend RetainPtr pdfium::MakeRetain(Args&&... args); diff --git a/core/fxcodec/codec/fx_codec.cpp b/core/fxcodec/codec/fx_codec.cpp index 54245a5b99..053aa71da2 100644 --- a/core/fxcodec/codec/fx_codec.cpp +++ b/core/fxcodec/codec/fx_codec.cpp @@ -1517,7 +1517,7 @@ CFX_DIBAttribute::~CFX_DIBAttribute() { } #endif // PDF_ENABLE_XFA -class CCodec_RLScanlineDecoder : public CCodec_ScanlineDecoder { +class CCodec_RLScanlineDecoder final : public CCodec_ScanlineDecoder { public: CCodec_RLScanlineDecoder(); ~CCodec_RLScanlineDecoder() override; diff --git a/core/fxcodec/codec/fx_codec_fax.cpp b/core/fxcodec/codec/fx_codec_fax.cpp index aabc110010..c6e71b6b60 100644 --- a/core/fxcodec/codec/fx_codec_fax.cpp +++ b/core/fxcodec/codec/fx_codec_fax.cpp @@ -447,7 +447,7 @@ void FaxGet1DLine(const uint8_t* src_buf, } // namespace -class CCodec_FaxDecoder : public CCodec_ScanlineDecoder { +class CCodec_FaxDecoder final : public CCodec_ScanlineDecoder { public: CCodec_FaxDecoder(const uint8_t* src_buf, uint32_t src_size, diff --git a/core/fxcodec/codec/fx_codec_flate.cpp b/core/fxcodec/codec/fx_codec_flate.cpp index 39d27a4955..11bdf67c42 100644 --- a/core/fxcodec/codec/fx_codec_flate.cpp +++ b/core/fxcodec/codec/fx_codec_flate.cpp @@ -623,7 +623,7 @@ uint32_t CCodec_FlateScanlineDecoder::GetSrcOffset() { return FlateGetPossiblyTruncatedTotalIn(m_pFlate.get()); } -class CCodec_FlatePredictorScanlineDecoder +class CCodec_FlatePredictorScanlineDecoder final : public CCodec_FlateScanlineDecoder { public: CCodec_FlatePredictorScanlineDecoder(const uint8_t* src_buf, diff --git a/core/fxcodec/codec/fx_codec_jpeg.cpp b/core/fxcodec/codec/fx_codec_jpeg.cpp index 4c37465386..d8e94b0285 100644 --- a/core/fxcodec/codec/fx_codec_jpeg.cpp +++ b/core/fxcodec/codec/fx_codec_jpeg.cpp @@ -29,7 +29,7 @@ extern "C" { #endif } // extern "C" -class CJpegContext : public CCodec_JpegModule::Context { +class CJpegContext final : public CCodec_JpegModule::Context { public: CJpegContext(); ~CJpegContext() override; @@ -162,7 +162,7 @@ static bool JpegLoadInfo(const uint8_t* src_buf, return true; } -class CCodec_JpegDecoder : public CCodec_ScanlineDecoder { +class CCodec_JpegDecoder final : public CCodec_ScanlineDecoder { public: CCodec_JpegDecoder(); ~CCodec_JpegDecoder() override; diff --git a/core/fxcodec/gif/cfx_gifcontext_unittest.cpp b/core/fxcodec/gif/cfx_gifcontext_unittest.cpp index 0d8941f72f..25f12b2724 100644 --- a/core/fxcodec/gif/cfx_gifcontext_unittest.cpp +++ b/core/fxcodec/gif/cfx_gifcontext_unittest.cpp @@ -7,7 +7,7 @@ #include "core/fxcrt/unowned_ptr.h" #include "testing/gtest/include/gtest/gtest.h" -class CFX_GifContextForTest : public CFX_GifContext { +class CFX_GifContextForTest final : public CFX_GifContext { public: CFX_GifContextForTest(CCodec_GifModule* gif_module, CCodec_GifModule::Delegate* delegate) -- cgit v1.2.3