From 87dffc0315477150c9c1964913b65bc97bdf654f Mon Sep 17 00:00:00 2001 From: dsinclair Date: Wed, 31 Aug 2016 06:03:49 -0700 Subject: Free the GifPlainText object when complete. We allocate the GifPlainText object on line ~685 inside GIF_D_STATUS_EXT_PTE. We cleanup the internal pointers in the gif_destroy_decompress() but we failed to cleanup the pointer itself. This CL frees the allocated pointer once the data is cleaned up. BUG=chromium:638499 Review-Url: https://codereview.chromium.org/2291143003 --- core/fxcodec/lgif/fx_gif.cpp | 1 + 1 file changed, 1 insertion(+) (limited to 'core/fxcodec') diff --git a/core/fxcodec/lgif/fx_gif.cpp b/core/fxcodec/lgif/fx_gif.cpp index b94445ccf3..08b008ddb4 100644 --- a/core/fxcodec/lgif/fx_gif.cpp +++ b/core/fxcodec/lgif/fx_gif.cpp @@ -418,6 +418,7 @@ void gif_destroy_decompress(gif_decompress_struct_pp gif_ptr_ptr) { FX_Free(p->gce_ptr); FX_Free(p->pte_ptr); delete p->string_ptr; + FX_Free(p); } gif_ptr->pt_ptr_arr_ptr->RemoveAll(); delete gif_ptr->pt_ptr_arr_ptr; -- cgit v1.2.3