From 3bb57514867a2bd10ba535e0b06de566a58d8085 Mon Sep 17 00:00:00 2001 From: Tom Sepez Date: Tue, 28 Mar 2017 14:09:43 -0700 Subject: Ensure that CFX_RetainPtr move ctor is used by std::vector. Add a test for one of our types that fails unless this is the case. Mark all our other move ctors as |noexcept|. Change-Id: Ib106f219183d5abf94504af420a43c94b8f40e22 Reviewed-on: https://pdfium-review.googlesource.com/3251 Commit-Queue: Tom Sepez Reviewed-by: dsinclair --- core/fxcrt/cfx_retain_ptr.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'core/fxcrt/cfx_retain_ptr.h') diff --git a/core/fxcrt/cfx_retain_ptr.h b/core/fxcrt/cfx_retain_ptr.h index 5db384f334..32a77c5a6c 100644 --- a/core/fxcrt/cfx_retain_ptr.h +++ b/core/fxcrt/cfx_retain_ptr.h @@ -22,7 +22,7 @@ class CFX_RetainPtr { CFX_RetainPtr() {} CFX_RetainPtr(const CFX_RetainPtr& that) : CFX_RetainPtr(that.Get()) {} - CFX_RetainPtr(CFX_RetainPtr&& that) { Swap(that); } + CFX_RetainPtr(CFX_RetainPtr&& that) noexcept { Swap(that); } // Deliberately implicit to allow returning nullptrs. CFX_RetainPtr(std::nullptr_t ptr) {} -- cgit v1.2.3