From fef62e1f2bbf064100e6e262a10653f2374bfd2b Mon Sep 17 00:00:00 2001 From: tsepez Date: Thu, 22 Sep 2016 11:37:13 -0700 Subject: Null CPDF_CountedObj::m_pObj prior to deletion This gives additional protection in case of re-entry. Also make CFX_CountRef more robust in face of errors. BUG=649229 Review-Url: https://codereview.chromium.org/2364673002 --- core/fxcrt/cfx_string_data_template.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'core/fxcrt/cfx_string_data_template.h') diff --git a/core/fxcrt/cfx_string_data_template.h b/core/fxcrt/cfx_string_data_template.h index 225020a7dd..5f7bfa1f83 100644 --- a/core/fxcrt/cfx_string_data_template.h +++ b/core/fxcrt/cfx_string_data_template.h @@ -85,7 +85,7 @@ class CFX_StringDataTemplate { // Since the count increments with each new pointer, the largest value is // the number of pointers that can fit into the address space. The size of // the address space itself is a good upper bound on it. - intptr_t m_nRefs; // Would prefer ssize_t, but no windows support. + intptr_t m_nRefs; // |FX_STRSIZE| is currently typedef'd as |int|. // TODO(palmer): It should be a |size_t|, or at least unsigned. -- cgit v1.2.3