From 8f53f54a9ccada2ea8651f2786f1bbee323f09b7 Mon Sep 17 00:00:00 2001 From: tsepez Date: Thu, 15 Sep 2016 11:55:00 -0700 Subject: Add short-cut in CFX_{Byte,Wide}String::Operator<() Strings are never less than themselves, and this will occur given the shared CoW nature of these strings. Review-Url: https://codereview.chromium.org/2347433004 --- core/fxcrt/fx_basic_bstring.cpp | 9 +++++++++ 1 file changed, 9 insertions(+) (limited to 'core/fxcrt/fx_basic_bstring.cpp') diff --git a/core/fxcrt/fx_basic_bstring.cpp b/core/fxcrt/fx_basic_bstring.cpp index 0b9d9873d8..c5979a7466 100644 --- a/core/fxcrt/fx_basic_bstring.cpp +++ b/core/fxcrt/fx_basic_bstring.cpp @@ -216,6 +216,15 @@ bool CFX_ByteString::operator==(const CFX_ByteString& other) const { m_pData->m_nDataLength) == 0; } +bool CFX_ByteString::operator<(const CFX_ByteString& str) const { + if (m_pData == str.m_pData) + return false; + + int result = FXSYS_memcmp(c_str(), str.c_str(), + std::min(GetLength(), str.GetLength())); + return result < 0 || (result == 0 && GetLength() < str.GetLength()); +} + bool CFX_ByteString::EqualNoCase(const CFX_ByteStringC& str) const { if (!m_pData) return str.IsEmpty(); -- cgit v1.2.3