From 670c4fdea0acb9663145b96bec1fbf76279781df Mon Sep 17 00:00:00 2001 From: Dan Sinclair Date: Thu, 31 Aug 2017 15:11:52 -0400 Subject: Cleanup fx_basic_* files Remove dead code, move code to namespaces where possible, cleanup some single use items. Change-Id: Ia734477ceb2105a1ed272463bd8220f1205a7ce9 Reviewed-on: https://pdfium-review.googlesource.com/12732 Commit-Queue: dsinclair Reviewed-by: Tom Sepez --- core/fxcrt/fx_basic_gcc_unittest.cpp | 26 -------------------------- 1 file changed, 26 deletions(-) (limited to 'core/fxcrt/fx_basic_gcc_unittest.cpp') diff --git a/core/fxcrt/fx_basic_gcc_unittest.cpp b/core/fxcrt/fx_basic_gcc_unittest.cpp index 665eede9ff..2960ee58c0 100644 --- a/core/fxcrt/fx_basic_gcc_unittest.cpp +++ b/core/fxcrt/fx_basic_gcc_unittest.cpp @@ -60,7 +60,6 @@ TEST(fxcrt, FXSYS_wtoi) { EXPECT_EQ(2147483647, FXSYS_wtoi(L"2147483647")); // The min value. EXPECT_EQ(-2147483647 - 1, FXSYS_wtoi(L"-2147483648")); - EXPECT_EQ(9, FXSYS_wtoi64(L"9x9")); // Out of range values. EXPECT_EQ(2147483647, FXSYS_wtoi(L"2147483623423412348")); @@ -68,31 +67,6 @@ TEST(fxcrt, FXSYS_wtoi) { EXPECT_EQ(-2147483647 - 1, FXSYS_wtoi(L"-2147483652")); } -TEST(fxcrt, FXSYS_wtoi64) { - EXPECT_EQ(0, FXSYS_wtoi64(L"")); - EXPECT_EQ(0, FXSYS_wtoi64(L"0")); - EXPECT_EQ(-1, FXSYS_wtoi64(L"-1")); - EXPECT_EQ(2345, FXSYS_wtoi64(L"2345")); - EXPECT_EQ(-9223372036854775807LL, FXSYS_wtoi64(L"-9223372036854775807")); - // Handle the sign. - EXPECT_EQ(-2345, FXSYS_wtoi64(L"-2345")); - EXPECT_EQ(2345, FXSYS_wtoi64(L"+2345")); - // The max value. - EXPECT_EQ(9223372036854775807LL, FXSYS_wtoi64(L"9223372036854775807")); - // The min value. - EXPECT_EQ(-9223372036854775807LL - 1LL, - FXSYS_wtoi64(L"-9223372036854775808")); - // With invalid char. - EXPECT_EQ(9, FXSYS_wtoi64(L"9x9")); - - // Out of range values. - EXPECT_EQ(9223372036854775807LL, - FXSYS_wtoi64(L"922337203685471234123475807")); - EXPECT_EQ(9223372036854775807LL, FXSYS_wtoi64(L"9223372036854775808")); - EXPECT_EQ(-9223372036854775807LL - 1LL, - FXSYS_wtoi64(L"-9223372036854775810")); -} - TEST(fxcrt, FXSYS_atoui) { EXPECT_EQ(0u, FXSYS_atoui("")); EXPECT_EQ(0u, FXSYS_atoui("0")); -- cgit v1.2.3