From 833619b4441915c7c55085d44b3221eaef0d9800 Mon Sep 17 00:00:00 2001 From: tsepez Date: Wed, 7 Dec 2016 09:21:17 -0800 Subject: Refcount all the IFX_ stream classes all the time. We can remove a lot of "bOwnsStream" logic in the process. Always pass these by const reference, in case the called method wants to hang on to the stream (one exception is where we stick a raw pointer into a void* slot in a context from another layer). Review-Url: https://codereview.chromium.org/2451493002 --- core/fxcrt/fx_xml.h | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) (limited to 'core/fxcrt/fx_xml.h') diff --git a/core/fxcrt/fx_xml.h b/core/fxcrt/fx_xml.h index 03337d0142..7f42a7fa9b 100644 --- a/core/fxcrt/fx_xml.h +++ b/core/fxcrt/fx_xml.h @@ -58,12 +58,13 @@ class CXML_Element { size_t size, bool bSaveSpaceChars = false, FX_FILESIZE* pParsedSize = nullptr); - static CXML_Element* Parse(IFX_SeekableReadStream* pFile, - bool bSaveSpaceChars = false, - FX_FILESIZE* pParsedSize = nullptr); - static CXML_Element* Parse(IFX_BufferedReadStream* pBuffer, + static CXML_Element* Parse(const CFX_RetainPtr& pFile, bool bSaveSpaceChars = false, FX_FILESIZE* pParsedSize = nullptr); + static CXML_Element* Parse( + const CFX_RetainPtr& pBuffer, + bool bSaveSpaceChars = false, + FX_FILESIZE* pParsedSize = nullptr); CXML_Element(const CFX_ByteStringC& qSpace, const CFX_ByteStringC& tagName); explicit CXML_Element(const CFX_ByteStringC& qTagName); -- cgit v1.2.3