From e00f75c2318d55dfa261f1915decd2545c44ccfb Mon Sep 17 00:00:00 2001 From: tsepez Date: Fri, 6 May 2016 13:15:46 -0700 Subject: CFX_ArabicChar contains only static methods, no need to instantiate. Review-Url: https://codereview.chromium.org/1954593004 --- core/fxcrt/include/fx_arabic.h | 27 ++++++++++----------------- 1 file changed, 10 insertions(+), 17 deletions(-) (limited to 'core/fxcrt/include/fx_arabic.h') diff --git a/core/fxcrt/include/fx_arabic.h b/core/fxcrt/include/fx_arabic.h index 96fa7954c3..2617d1897f 100644 --- a/core/fxcrt/include/fx_arabic.h +++ b/core/fxcrt/include/fx_arabic.h @@ -14,25 +14,18 @@ #define FX_BidiGetDeferredType(a) (((a) >> 4) & 0x0F) #define FX_BidiGetResolvedType(a) ((a)&0x0F) -class CFX_ArabicChar { - public: - void Release() { delete this; } +namespace pdfium { +namespace arabic { - FX_BOOL IsArabicChar(FX_WCHAR wch) const; - FX_BOOL IsArabicFormChar(FX_WCHAR wch) const; +bool IsArabicChar(FX_WCHAR wch); +bool IsArabicFormChar(FX_WCHAR wch); +FX_WCHAR GetFormChar(FX_WCHAR wch, FX_WCHAR prev = 0, FX_WCHAR next = 0); +FX_WCHAR GetFormChar(const CFX_Char* cur, + const CFX_Char* prev, + const CFX_Char* next); - FX_WCHAR GetFormChar(FX_WCHAR wch, - FX_WCHAR prev = 0, - FX_WCHAR next = 0) const; - FX_WCHAR GetFormChar(const CFX_Char* cur, - const CFX_Char* prev, - const CFX_Char* next) const; - - protected: - const FX_ARBFORMTABLE* ParseChar(const CFX_Char* pTC, - FX_WCHAR& wChar, - FX_CHARTYPE& eType) const; -}; +} // namespace arabic +} // namespace pdfium void FX_BidiReverseString(CFX_WideString& wsText, int32_t iStart, -- cgit v1.2.3