From d4e7ca034cbbe29911b08eb5c252aa0d05b6a429 Mon Sep 17 00:00:00 2001 From: Tom Sepez Date: Thu, 30 Aug 2018 22:40:07 +0000 Subject: Add unit test for AutoRestorer<> on smart pointer types. Test UnownedPtr<> and RetainPtr<>. We cannot operate against std::unique_ptr<> because we need a copyable type. Add test for self-reassignment on going out of scope. Move one test helper class to testing/ so it can be shared among unit tests. Allow it to recognize if it ever gets "destroyed", otherwise we can't be sure Retain/Release applied in the correct order. Change-Id: I13056094c70079f7283cbc7600948f81a64874b4 Reviewed-on: https://pdfium-review.googlesource.com/41690 Reviewed-by: Lei Zhang Commit-Queue: Tom Sepez --- core/fxcrt/retain_ptr_unittest.cpp | 17 +---------------- 1 file changed, 1 insertion(+), 16 deletions(-) (limited to 'core/fxcrt/retain_ptr_unittest.cpp') diff --git a/core/fxcrt/retain_ptr_unittest.cpp b/core/fxcrt/retain_ptr_unittest.cpp index f4b2994eae..5548e9bfd7 100644 --- a/core/fxcrt/retain_ptr_unittest.cpp +++ b/core/fxcrt/retain_ptr_unittest.cpp @@ -8,24 +8,9 @@ #include #include "testing/gtest/include/gtest/gtest.h" +#include "testing/pseudo_retainable.h" namespace fxcrt { -namespace { - -class PseudoRetainable { - public: - PseudoRetainable() : retain_count_(0), release_count_(0) {} - void Retain() { ++retain_count_; } - void Release() { ++release_count_; } - int retain_count() const { return retain_count_; } - int release_count() const { return release_count_; } - - private: - int retain_count_; - int release_count_; -}; - -} // namespace TEST(RetainPtr, Null) { RetainPtr ptr; -- cgit v1.2.3