From 7afdad5ab7a1bd54ddf6f2a823be30d4b8e39567 Mon Sep 17 00:00:00 2001 From: dan sinclair Date: Fri, 13 Apr 2018 00:22:55 +0000 Subject: Make CFX_XMLInstruction a subclass of CFX_XMLNode The CFX_XMLInstruction handles the blocks at the top of an XML file. It was inheriting from CFX_XMLAttributeNode in order to store the tag name. This CL moves the tag name into CFX_XMLInstruction and subclasses from CFX_XMLNode. Change-Id: I8f7ff0dde19ed43b46d095b0d45df4bf06875af5 Reviewed-on: https://pdfium-review.googlesource.com/30490 Commit-Queue: dsinclair Reviewed-by: Henrique Nakashima --- core/fxcrt/xml/cfx_xmlinstruction.h | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) (limited to 'core/fxcrt/xml/cfx_xmlinstruction.h') diff --git a/core/fxcrt/xml/cfx_xmlinstruction.h b/core/fxcrt/xml/cfx_xmlinstruction.h index 415a86a379..cbdf9e2538 100644 --- a/core/fxcrt/xml/cfx_xmlinstruction.h +++ b/core/fxcrt/xml/cfx_xmlinstruction.h @@ -13,7 +13,7 @@ #include "core/fxcrt/fx_string.h" #include "core/fxcrt/xml/cfx_xmlattributenode.h" -class CFX_XMLInstruction : public CFX_XMLAttributeNode { +class CFX_XMLInstruction : public CFX_XMLNode { public: explicit CFX_XMLInstruction(const WideString& wsTarget); ~CFX_XMLInstruction() override; @@ -23,11 +23,14 @@ class CFX_XMLInstruction : public CFX_XMLAttributeNode { std::unique_ptr Clone() override; void Save(const RetainPtr& pXMLStream) override; + bool IsOriginalXFAVersion() const; + bool IsAcrobat() const; + const std::vector& GetTargetData() const { return m_TargetData; } void AppendData(const WideString& wsData); - void RemoveData(int32_t index); private: + WideString name_; std::vector m_TargetData; }; -- cgit v1.2.3