From 35d4587eceb07cad6b38675b0ebb4b73eca3a62b Mon Sep 17 00:00:00 2001 From: Lei Zhang Date: Fri, 12 Oct 2018 19:07:03 +0000 Subject: Remove more unnecessary includes and do IWYU as needed. Also move some implementations out of headers. Change-Id: I321fc26970c440d874b135bd28e8bc8156b9afee Reviewed-on: https://pdfium-review.googlesource.com/c/43890 Commit-Queue: Lei Zhang Reviewed-by: Tom Sepez --- core/fxcrt/css/cfx_csscomputedstyle.cpp | 1 - core/fxcrt/fx_arabic.cpp | 1 - core/fxcrt/fx_bidi.cpp | 1 + core/fxcrt/fx_extension.h | 1 - core/fxcrt/pdfium_span_unittest.cpp | 1 - core/fxcrt/widestring_unittest.cpp | 2 ++ core/fxcrt/xml/cfx_xmlelement.cpp | 1 - core/fxcrt/xml/cfx_xmlinstruction.cpp | 1 - core/fxcrt/xml/cfx_xmlnode.cpp | 1 - 9 files changed, 3 insertions(+), 7 deletions(-) (limited to 'core/fxcrt') diff --git a/core/fxcrt/css/cfx_csscomputedstyle.cpp b/core/fxcrt/css/cfx_csscomputedstyle.cpp index f06092c7f9..eff708122b 100644 --- a/core/fxcrt/css/cfx_csscomputedstyle.cpp +++ b/core/fxcrt/css/cfx_csscomputedstyle.cpp @@ -8,7 +8,6 @@ #include "core/fxcrt/css/cfx_cssstringvalue.h" #include "core/fxcrt/css/cfx_cssvaluelist.h" -#include "third_party/base/stl_util.h" CFX_CSSComputedStyle::CFX_CSSComputedStyle() {} diff --git a/core/fxcrt/fx_arabic.cpp b/core/fxcrt/fx_arabic.cpp index 0d6f0395a6..6d049bd427 100644 --- a/core/fxcrt/fx_arabic.cpp +++ b/core/fxcrt/fx_arabic.cpp @@ -11,7 +11,6 @@ #include "core/fxcrt/fx_memory.h" #include "core/fxcrt/fx_unicode.h" -#include "third_party/base/stl_util.h" namespace { diff --git a/core/fxcrt/fx_bidi.cpp b/core/fxcrt/fx_bidi.cpp index 672e2d9dae..29eb6ead55 100644 --- a/core/fxcrt/fx_bidi.cpp +++ b/core/fxcrt/fx_bidi.cpp @@ -9,6 +9,7 @@ #include #include "core/fxcrt/fx_unicode.h" +#include "third_party/base/stl_util.h" #ifdef PDF_ENABLE_XFA #include "core/fxcrt/fx_extension.h" diff --git a/core/fxcrt/fx_extension.h b/core/fxcrt/fx_extension.h index d1ea795fa8..c1cd188c81 100644 --- a/core/fxcrt/fx_extension.h +++ b/core/fxcrt/fx_extension.h @@ -13,7 +13,6 @@ #include #include "core/fxcrt/fx_string.h" -#include "third_party/base/span.h" #if defined(USE_SYSTEM_ICUUC) #include diff --git a/core/fxcrt/pdfium_span_unittest.cpp b/core/fxcrt/pdfium_span_unittest.cpp index 177bc4097e..6778bbb145 100644 --- a/core/fxcrt/pdfium_span_unittest.cpp +++ b/core/fxcrt/pdfium_span_unittest.cpp @@ -4,7 +4,6 @@ #include "testing/gtest/include/gtest/gtest.h" #include "third_party/base/span.h" -#include "third_party/base/stl_util.h" // Tests PDFium-modifications to base::span. The name of this file is // chosen to avoid collisions with base's span_unittest.cc diff --git a/core/fxcrt/widestring_unittest.cpp b/core/fxcrt/widestring_unittest.cpp index 160dc929db..0d20d71200 100644 --- a/core/fxcrt/widestring_unittest.cpp +++ b/core/fxcrt/widestring_unittest.cpp @@ -10,6 +10,8 @@ #include "core/fxcrt/fx_string.h" #include "testing/gtest/include/gtest/gtest.h" +#include "third_party/base/span.h" +#include "third_party/base/stl_util.h" namespace fxcrt { diff --git a/core/fxcrt/xml/cfx_xmlelement.cpp b/core/fxcrt/xml/cfx_xmlelement.cpp index f5031624e8..434b474df7 100644 --- a/core/fxcrt/xml/cfx_xmlelement.cpp +++ b/core/fxcrt/xml/cfx_xmlelement.cpp @@ -13,7 +13,6 @@ #include "core/fxcrt/xml/cfx_xmlchardata.h" #include "core/fxcrt/xml/cfx_xmldocument.h" #include "core/fxcrt/xml/cfx_xmltext.h" -#include "third_party/base/stl_util.h" CFX_XMLElement::CFX_XMLElement(const WideString& wsTag) : CFX_XMLNode(), name_(wsTag) { diff --git a/core/fxcrt/xml/cfx_xmlinstruction.cpp b/core/fxcrt/xml/cfx_xmlinstruction.cpp index 9c00e38528..e0af2d1c95 100644 --- a/core/fxcrt/xml/cfx_xmlinstruction.cpp +++ b/core/fxcrt/xml/cfx_xmlinstruction.cpp @@ -11,7 +11,6 @@ #include "core/fxcrt/fx_codepage.h" #include "core/fxcrt/fx_extension.h" #include "core/fxcrt/xml/cfx_xmldocument.h" -#include "third_party/base/stl_util.h" CFX_XMLInstruction::CFX_XMLInstruction(const WideString& wsTarget) : CFX_XMLNode(), name_(wsTarget) {} diff --git a/core/fxcrt/xml/cfx_xmlnode.cpp b/core/fxcrt/xml/cfx_xmlnode.cpp index c8fea23bda..59eb3f77ce 100644 --- a/core/fxcrt/xml/cfx_xmlnode.cpp +++ b/core/fxcrt/xml/cfx_xmlnode.cpp @@ -13,7 +13,6 @@ #include "core/fxcrt/xml/cfx_xmlelement.h" #include "core/fxcrt/xml/cfx_xmlinstruction.h" #include "core/fxcrt/xml/cfx_xmltext.h" -#include "third_party/base/stl_util.h" CFX_XMLNode::CFX_XMLNode() = default; -- cgit v1.2.3