From 39cf6a765ae349242289ec3287eaf4d6c5fd57f8 Mon Sep 17 00:00:00 2001 From: Tom Sepez Date: Thu, 4 Oct 2018 23:33:30 +0000 Subject: Change |virtual ~Foo(){}| to |virtual ~Foo()=default;| Otherwise code coverage flags the empty body as unreachable. Change-Id: Iee1d9a876d68276529c70d9b8c7a28276f271767 Reviewed-on: https://pdfium-review.googlesource.com/c/43514 Reviewed-by: Lei Zhang Commit-Queue: Tom Sepez --- core/fxcrt/fileaccess_iface.h | 2 +- core/fxcrt/locale_iface.h | 2 +- core/fxcrt/pauseindicator_iface.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) (limited to 'core/fxcrt') diff --git a/core/fxcrt/fileaccess_iface.h b/core/fxcrt/fileaccess_iface.h index 210080e438..fdabc7465e 100644 --- a/core/fxcrt/fileaccess_iface.h +++ b/core/fxcrt/fileaccess_iface.h @@ -16,7 +16,7 @@ class FileAccessIface { public: static std::unique_ptr Create(); - virtual ~FileAccessIface() {} + virtual ~FileAccessIface() = default; virtual bool Open(const ByteStringView& fileName, uint32_t dwMode) = 0; virtual bool Open(const WideStringView& fileName, uint32_t dwMode) = 0; diff --git a/core/fxcrt/locale_iface.h b/core/fxcrt/locale_iface.h index 7e0ca6fd32..7ee18d93b8 100644 --- a/core/fxcrt/locale_iface.h +++ b/core/fxcrt/locale_iface.h @@ -46,7 +46,7 @@ enum FX_DATETIMETYPE { class LocaleIface { public: - virtual ~LocaleIface() {} + virtual ~LocaleIface() = default; virtual WideString GetName() const = 0; virtual WideString GetDecimalSymbol() const = 0; diff --git a/core/fxcrt/pauseindicator_iface.h b/core/fxcrt/pauseindicator_iface.h index c12b02e427..d5d856d94f 100644 --- a/core/fxcrt/pauseindicator_iface.h +++ b/core/fxcrt/pauseindicator_iface.h @@ -9,7 +9,7 @@ class PauseIndicatorIface { public: - virtual ~PauseIndicatorIface() {} + virtual ~PauseIndicatorIface() = default; virtual bool NeedToPauseNow() = 0; }; -- cgit v1.2.3