From 55865454c43fbc3b163cff166544ba0a060dcbc4 Mon Sep 17 00:00:00 2001 From: Tom Sepez Date: Mon, 27 Aug 2018 20:18:04 +0000 Subject: The final game: mark everything final. Then revert the ones that break compilation. Fix one IWYU noticed during presubmit. Change-Id: I881a8a72818e55dbc4816247e35ff5e3015194e7 Reviewed-on: https://pdfium-review.googlesource.com/41470 Reviewed-by: Lei Zhang Commit-Queue: Tom Sepez --- core/fxcrt/cfx_fileaccess_posix.h | 2 +- core/fxcrt/cfx_fileaccess_windows.h | 2 +- core/fxcrt/cfx_memorystream.h | 2 +- core/fxcrt/cfx_seekablemultistream.h | 2 +- core/fxcrt/cfx_seekablestreamproxy.h | 2 +- core/fxcrt/cfx_widetextbuf.h | 2 +- core/fxcrt/css/cfx_csscolorvalue.h | 2 +- core/fxcrt/css/cfx_csscomputedstyle.h | 2 +- core/fxcrt/css/cfx_cssenumvalue.h | 2 +- core/fxcrt/css/cfx_cssnumbervalue.h | 2 +- core/fxcrt/css/cfx_cssstringvalue.h | 2 +- core/fxcrt/css/cfx_cssvaluelist.h | 2 +- core/fxcrt/fx_coordinates.h | 2 +- core/fxcrt/observable_unittest.cpp | 2 +- core/fxcrt/shared_copy_on_write_unittest.cpp | 2 +- core/fxcrt/xml/cfx_xmlchardata.h | 2 +- core/fxcrt/xml/cfx_xmlelement.h | 2 +- core/fxcrt/xml/cfx_xmlinstruction.h | 2 +- 18 files changed, 18 insertions(+), 18 deletions(-) (limited to 'core/fxcrt') diff --git a/core/fxcrt/cfx_fileaccess_posix.h b/core/fxcrt/cfx_fileaccess_posix.h index 381f115a13..7b8230de18 100644 --- a/core/fxcrt/cfx_fileaccess_posix.h +++ b/core/fxcrt/cfx_fileaccess_posix.h @@ -16,7 +16,7 @@ #error "Included on the wrong platform" #endif -class CFX_FileAccess_Posix : public FileAccessIface { +class CFX_FileAccess_Posix final : public FileAccessIface { public: CFX_FileAccess_Posix(); ~CFX_FileAccess_Posix() override; diff --git a/core/fxcrt/cfx_fileaccess_windows.h b/core/fxcrt/cfx_fileaccess_windows.h index 4352a2b521..fad2ed6f94 100644 --- a/core/fxcrt/cfx_fileaccess_windows.h +++ b/core/fxcrt/cfx_fileaccess_windows.h @@ -14,7 +14,7 @@ #error "Included on the wrong platform" #endif -class CFX_FileAccess_Windows : public FileAccessIface { +class CFX_FileAccess_Windows final : public FileAccessIface { public: CFX_FileAccess_Windows(); ~CFX_FileAccess_Windows() override; diff --git a/core/fxcrt/cfx_memorystream.h b/core/fxcrt/cfx_memorystream.h index 99e39a8ef3..c09c39011b 100644 --- a/core/fxcrt/cfx_memorystream.h +++ b/core/fxcrt/cfx_memorystream.h @@ -13,7 +13,7 @@ #include "core/fxcrt/fx_stream.h" #include "core/fxcrt/retain_ptr.h" -class CFX_MemoryStream : public IFX_SeekableStream { +class CFX_MemoryStream final : public IFX_SeekableStream { public: template friend RetainPtr pdfium::MakeRetain(Args&&... args); diff --git a/core/fxcrt/cfx_seekablemultistream.h b/core/fxcrt/cfx_seekablemultistream.h index 4bd26b9863..ac15386b99 100644 --- a/core/fxcrt/cfx_seekablemultistream.h +++ b/core/fxcrt/cfx_seekablemultistream.h @@ -15,7 +15,7 @@ class CPDF_Stream; class CPDF_StreamAcc; -class CFX_SeekableMultiStream : public IFX_SeekableStream { +class CFX_SeekableMultiStream final : public IFX_SeekableStream { public: explicit CFX_SeekableMultiStream( const std::vector& streams); diff --git a/core/fxcrt/cfx_seekablestreamproxy.h b/core/fxcrt/cfx_seekablestreamproxy.h index 9b6b3a11c9..b193b1801a 100644 --- a/core/fxcrt/cfx_seekablestreamproxy.h +++ b/core/fxcrt/cfx_seekablestreamproxy.h @@ -13,7 +13,7 @@ #include "core/fxcrt/fx_system.h" #include "core/fxcrt/retain_ptr.h" -class CFX_SeekableStreamProxy : public IFX_SeekableReadStream { +class CFX_SeekableStreamProxy final : public IFX_SeekableReadStream { public: enum class From { Begin = 0, diff --git a/core/fxcrt/cfx_widetextbuf.h b/core/fxcrt/cfx_widetextbuf.h index 84553a3e59..483f75d318 100644 --- a/core/fxcrt/cfx_widetextbuf.h +++ b/core/fxcrt/cfx_widetextbuf.h @@ -11,7 +11,7 @@ #include "core/fxcrt/fx_string.h" #include "core/fxcrt/fx_system.h" -class CFX_WideTextBuf : public CFX_BinaryBuf { +class CFX_WideTextBuf final : public CFX_BinaryBuf { public: void AppendChar(wchar_t wch); size_t GetLength() const override; diff --git a/core/fxcrt/css/cfx_csscolorvalue.h b/core/fxcrt/css/cfx_csscolorvalue.h index f59c0c5d3d..0156caa786 100644 --- a/core/fxcrt/css/cfx_csscolorvalue.h +++ b/core/fxcrt/css/cfx_csscolorvalue.h @@ -9,7 +9,7 @@ #include "core/fxcrt/css/cfx_cssvalue.h" -class CFX_CSSColorValue : public CFX_CSSValue { +class CFX_CSSColorValue final : public CFX_CSSValue { public: explicit CFX_CSSColorValue(FX_ARGB color); ~CFX_CSSColorValue() override; diff --git a/core/fxcrt/css/cfx_csscomputedstyle.h b/core/fxcrt/css/cfx_csscomputedstyle.h index 5080a7a3c2..f97f3f1d7d 100644 --- a/core/fxcrt/css/cfx_csscomputedstyle.h +++ b/core/fxcrt/css/cfx_csscomputedstyle.h @@ -15,7 +15,7 @@ class CFX_CSSValueList; -class CFX_CSSComputedStyle : public Retainable { +class CFX_CSSComputedStyle final : public Retainable { public: class InheritedData { public: diff --git a/core/fxcrt/css/cfx_cssenumvalue.h b/core/fxcrt/css/cfx_cssenumvalue.h index 0d6b87e85d..c397761d5a 100644 --- a/core/fxcrt/css/cfx_cssenumvalue.h +++ b/core/fxcrt/css/cfx_cssenumvalue.h @@ -9,7 +9,7 @@ #include "core/fxcrt/css/cfx_cssvalue.h" -class CFX_CSSEnumValue : public CFX_CSSValue { +class CFX_CSSEnumValue final : public CFX_CSSValue { public: explicit CFX_CSSEnumValue(CFX_CSSPropertyValue value); ~CFX_CSSEnumValue() override; diff --git a/core/fxcrt/css/cfx_cssnumbervalue.h b/core/fxcrt/css/cfx_cssnumbervalue.h index a49328d663..a977750f08 100644 --- a/core/fxcrt/css/cfx_cssnumbervalue.h +++ b/core/fxcrt/css/cfx_cssnumbervalue.h @@ -23,7 +23,7 @@ enum class CFX_CSSNumberType { Picas, }; -class CFX_CSSNumberValue : public CFX_CSSValue { +class CFX_CSSNumberValue final : public CFX_CSSValue { public: CFX_CSSNumberValue(CFX_CSSNumberType type, float value); ~CFX_CSSNumberValue() override; diff --git a/core/fxcrt/css/cfx_cssstringvalue.h b/core/fxcrt/css/cfx_cssstringvalue.h index d72078a630..d49393c305 100644 --- a/core/fxcrt/css/cfx_cssstringvalue.h +++ b/core/fxcrt/css/cfx_cssstringvalue.h @@ -9,7 +9,7 @@ #include "core/fxcrt/css/cfx_cssvalue.h" -class CFX_CSSStringValue : public CFX_CSSValue { +class CFX_CSSStringValue final : public CFX_CSSValue { public: explicit CFX_CSSStringValue(const WideString& value); ~CFX_CSSStringValue() override; diff --git a/core/fxcrt/css/cfx_cssvaluelist.h b/core/fxcrt/css/cfx_cssvaluelist.h index d2b0c6e7d1..5e04c649b9 100644 --- a/core/fxcrt/css/cfx_cssvaluelist.h +++ b/core/fxcrt/css/cfx_cssvaluelist.h @@ -11,7 +11,7 @@ #include "core/fxcrt/css/cfx_cssvalue.h" -class CFX_CSSValueList : public CFX_CSSValue { +class CFX_CSSValueList final : public CFX_CSSValue { public: explicit CFX_CSSValueList(std::vector>& list); ~CFX_CSSValueList() override; diff --git a/core/fxcrt/fx_coordinates.h b/core/fxcrt/fx_coordinates.h index f84c5ee220..05e60c47b5 100644 --- a/core/fxcrt/fx_coordinates.h +++ b/core/fxcrt/fx_coordinates.h @@ -132,7 +132,7 @@ using CFX_Size = CFX_STemplate; using CFX_SizeF = CFX_STemplate; template -class CFX_VTemplate : public CFX_PTemplate { +class CFX_VTemplate final : public CFX_PTemplate { public: using CFX_PTemplate::x; using CFX_PTemplate::y; diff --git a/core/fxcrt/observable_unittest.cpp b/core/fxcrt/observable_unittest.cpp index 63e61b8513..5c55805afb 100644 --- a/core/fxcrt/observable_unittest.cpp +++ b/core/fxcrt/observable_unittest.cpp @@ -12,7 +12,7 @@ namespace fxcrt { namespace { -class PseudoObservable : public Observable { +class PseudoObservable final : public Observable { public: PseudoObservable() {} int SomeMethod() { return 42; } diff --git a/core/fxcrt/shared_copy_on_write_unittest.cpp b/core/fxcrt/shared_copy_on_write_unittest.cpp index 57e33d1019..6764c69300 100644 --- a/core/fxcrt/shared_copy_on_write_unittest.cpp +++ b/core/fxcrt/shared_copy_on_write_unittest.cpp @@ -29,7 +29,7 @@ class Observer { std::map destruction_counts_; }; -class Object : public Retainable { +class Object final : public Retainable { public: Object(Observer* observer, const std::string& name) : name_(name), observer_(observer) { diff --git a/core/fxcrt/xml/cfx_xmlchardata.h b/core/fxcrt/xml/cfx_xmlchardata.h index 9e5669a464..71e9407ca2 100644 --- a/core/fxcrt/xml/cfx_xmlchardata.h +++ b/core/fxcrt/xml/cfx_xmlchardata.h @@ -14,7 +14,7 @@ class CFX_XMLDocument; -class CFX_XMLCharData : public CFX_XMLText { +class CFX_XMLCharData final : public CFX_XMLText { public: explicit CFX_XMLCharData(const WideString& wsCData); ~CFX_XMLCharData() override; diff --git a/core/fxcrt/xml/cfx_xmlelement.h b/core/fxcrt/xml/cfx_xmlelement.h index 394866042c..f54587c4e4 100644 --- a/core/fxcrt/xml/cfx_xmlelement.h +++ b/core/fxcrt/xml/cfx_xmlelement.h @@ -16,7 +16,7 @@ class CFX_XMLDocument; -class CFX_XMLElement : public CFX_XMLNode { +class CFX_XMLElement final : public CFX_XMLNode { public: explicit CFX_XMLElement(const WideString& wsTag); ~CFX_XMLElement() override; diff --git a/core/fxcrt/xml/cfx_xmlinstruction.h b/core/fxcrt/xml/cfx_xmlinstruction.h index 8962d73ac1..18f84c3c3d 100644 --- a/core/fxcrt/xml/cfx_xmlinstruction.h +++ b/core/fxcrt/xml/cfx_xmlinstruction.h @@ -15,7 +15,7 @@ class CFX_XMLDocument; -class CFX_XMLInstruction : public CFX_XMLNode { +class CFX_XMLInstruction final : public CFX_XMLNode { public: explicit CFX_XMLInstruction(const WideString& wsTarget); ~CFX_XMLInstruction() override; -- cgit v1.2.3