From f6ecadb7aea68fb322bfa1dfce703a24cbd1e395 Mon Sep 17 00:00:00 2001 From: Nico Weber Date: Sat, 10 Feb 2018 00:51:00 +0000 Subject: Renable -Wimplicit-fallthrough for PDFium. Didn't find any bugs, but also doesn't require much boilerplate. Bug: TODO Change-Id: I5f30183c55216f1333c79fcb46476d281720873e Reviewed-on: https://pdfium-review.googlesource.com/26210 Reviewed-by: Lei Zhang Commit-Queue: Nico Weber --- core/fxge/agg/fx_agg_driver.cpp | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) (limited to 'core/fxge/agg') diff --git a/core/fxge/agg/fx_agg_driver.cpp b/core/fxge/agg/fx_agg_driver.cpp index b394facace..922f39efcd 100644 --- a/core/fxge/agg/fx_agg_driver.cpp +++ b/core/fxge/agg/fx_agg_driver.cpp @@ -15,6 +15,14 @@ #include "core/fxge/cfx_pathdata.h" #include "core/fxge/dib/cfx_imagerenderer.h" #include "core/fxge/dib/cfx_imagestretcher.h" +#include "third_party/base/ptr_util.h" +#include "third_party/base/stl_util.h" + +// Ignore fallthrough warnings in agg23 headers. +#if defined(__clang__) +#pragma GCC diagnostic push +#pragma GCC diagnostic ignored "-Wimplicit-fallthrough" +#endif #include "third_party/agg23/agg_conv_dash.h" #include "third_party/agg23/agg_conv_stroke.h" #include "third_party/agg23/agg_curves.h" @@ -23,8 +31,9 @@ #include "third_party/agg23/agg_rasterizer_scanline_aa.h" #include "third_party/agg23/agg_renderer_scanline.h" #include "third_party/agg23/agg_scanline_u.h" -#include "third_party/base/ptr_util.h" -#include "third_party/base/stl_util.h" +#if defined(__clang__) +#pragma GCC diagnostic pop +#endif namespace { -- cgit v1.2.3