From 85ba2610cf05a75b52681f381bba2da3ba37b984 Mon Sep 17 00:00:00 2001 From: Lei Zhang Date: Tue, 10 Apr 2018 17:55:46 +0000 Subject: Change FillRectWithBlend methods to take FX_RECT by const-ref. They currently take const FX_RECT*, but the pointer is never nullptr. Also add a comment to explain why FX_RECT is the way it is. It has the same layout as a win32 RECT. Change-Id: Icf0e4c3eb25fe03317590a736578e053b9dccf7a Reviewed-on: https://pdfium-review.googlesource.com/30051 Commit-Queue: Ryan Harrison Reviewed-by: Ryan Harrison --- core/fxge/cfx_renderdevice.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'core/fxge/cfx_renderdevice.h') diff --git a/core/fxge/cfx_renderdevice.h b/core/fxge/cfx_renderdevice.h index 124e5e9995..6c91d55140 100644 --- a/core/fxge/cfx_renderdevice.h +++ b/core/fxge/cfx_renderdevice.h @@ -145,7 +145,7 @@ class CFX_RenderDevice { int fill_mode, int blend_type); bool FillRect(const FX_RECT* pRect, uint32_t color) { - return FillRectWithBlend(pRect, color, FXDIB_BLEND_NORMAL); + return FillRectWithBlend(*pRect, color, FXDIB_BLEND_NORMAL); } RetainPtr GetBackDrop(); @@ -290,7 +290,7 @@ class CFX_RenderDevice { uint32_t color, int fill_mode, int blend_type); - bool FillRectWithBlend(const FX_RECT* pRect, uint32_t color, int blend_type); + bool FillRectWithBlend(const FX_RECT& rect, uint32_t color, int blend_type); RetainPtr m_pBitmap; int m_Width; -- cgit v1.2.3