From 5883300439287ab46559231ce8aed11e92bbc97c Mon Sep 17 00:00:00 2001 From: Lei Zhang Date: Fri, 26 Oct 2018 22:52:48 +0000 Subject: Replace int flags with struct FXDIB_ResampleOptions. Using bit values in an int may not be reliable, since different parts of the code can interpret the bits differently. e.g. FXDIB_DOWNSAMPLE and RENDER_FORCE_DOWNSAMPLE are defined in different places, but can be used interchangeably because they just happen to have the same value. It works but is rather fragile. Instead, use a struct of bools to explicitly define what different bits mean. Remove FXDIB_DOWNSAMPLE and friends. Change-Id: I9cf0c8f94d1ed27edf8dba22b0ab0ee67f2722cc Reviewed-on: https://pdfium-review.googlesource.com/c/44650 Commit-Queue: Lei Zhang Reviewed-by: Tom Sepez --- core/fxge/dib/cfx_dibbase.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'core/fxge/dib/cfx_dibbase.h') diff --git a/core/fxge/dib/cfx_dibbase.h b/core/fxge/dib/cfx_dibbase.h index 81b0691563..23d65a3cda 100644 --- a/core/fxge/dib/cfx_dibbase.h +++ b/core/fxge/dib/cfx_dibbase.h @@ -80,7 +80,7 @@ class CFX_DIBBase : public Retainable { RetainPtr CloneConvert(FXDIB_Format format); RetainPtr StretchTo(int dest_width, int dest_height, - uint32_t flags, + const FXDIB_ResampleOptions& options, const FX_RECT* pClip); RetainPtr TransformTo(const CFX_Matrix& mtDest, int* left, -- cgit v1.2.3