From caf6d61fbb38083f213a9d3441e12c5082d3ad3a Mon Sep 17 00:00:00 2001 From: Nicolas Pena Date: Thu, 29 Jun 2017 17:02:48 -0400 Subject: Move Start to constructor in CFX_Image(Renderer|Transformer) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The bool returned by Start was not being used and the method was always called right after the constructor, so it should be in the constructor. Change-Id: I98abf9f7c11fbe42b3aa15ec5e46731198aa23d5 Reviewed-on: https://pdfium-review.googlesource.com/7151 Commit-Queue: Nicolás Peña Reviewed-by: Lei Zhang --- core/fxge/skia/fx_skia_device.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'core/fxge/skia/fx_skia_device.cpp') diff --git a/core/fxge/skia/fx_skia_device.cpp b/core/fxge/skia/fx_skia_device.cpp index f4b72fe2ad..7e0d55688c 100644 --- a/core/fxge/skia/fx_skia_device.cpp +++ b/core/fxge/skia/fx_skia_device.cpp @@ -2174,9 +2174,9 @@ bool CFX_SkiaDeviceDriver::StartDIBits( if (!m_pBitmap->GetBuffer()) return true; m_pBitmap->UnPreMultiply(); - *handle = pdfium::MakeUnique(); - (*handle)->Start(m_pBitmap, m_pClipRgn.get(), pSource, bitmap_alpha, argb, - pMatrix, render_flags, m_bRgbByteOrder); + *handle = pdfium::MakeUnique( + m_pBitmap, m_pClipRgn.get(), pSource, bitmap_alpha, argb, pMatrix, + render_flags, m_bRgbByteOrder); #endif // _SKIA_SUPPORT_PATHS_ return true; } -- cgit v1.2.3