From 035359cd8ddb555fa33b6133db4fd405e4660712 Mon Sep 17 00:00:00 2001 From: Tom Sepez Date: Wed, 9 Dec 2015 16:26:21 -0800 Subject: Get rid of most uses of CFX_PtrArray. I didn't go whole hog and replace these with std::vector, but in the mean time, it is silly to cast a typedef for a template instantiated against void* when we can just instantiate the template against the actual type. The ones that remain are actual heterogeneous arrays with wacky casting. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1518593002 . --- core/include/fpdfdoc/fpdf_doc.h | 26 +++++++++----------------- 1 file changed, 9 insertions(+), 17 deletions(-) (limited to 'core/include/fpdfdoc/fpdf_doc.h') diff --git a/core/include/fpdfdoc/fpdf_doc.h b/core/include/fpdfdoc/fpdf_doc.h index 9b86e0ecb1..3dea48d3ed 100644 --- a/core/include/fpdfdoc/fpdf_doc.h +++ b/core/include/fpdfdoc/fpdf_doc.h @@ -753,9 +753,7 @@ class CPDF_FormField { int CountControls() { return m_ControlList.GetSize(); } - CPDF_FormControl* GetControl(int index) { - return (CPDF_FormControl*)m_ControlList.GetAt(index); - } + CPDF_FormControl* GetControl(int index) { return m_ControlList.GetAt(index); } int GetControlIndex(const CPDF_FormControl* pControl); @@ -831,21 +829,8 @@ class CPDF_FormField { protected: CPDF_FormField(CPDF_InterForm* pForm, CPDF_Dictionary* pDict); - ~CPDF_FormField(); - CPDF_FormField::Type m_Type; - - FX_DWORD m_Flags; - - CPDF_InterForm* m_pForm; - - CPDF_Dictionary* m_pDict; - - CFX_PtrArray m_ControlList; - friend class CPDF_InterForm; - friend class CPDF_FormControl; - CFX_WideString GetValue(FX_BOOL bDefault); FX_BOOL SetValue(const CFX_WideString& value, @@ -868,9 +853,16 @@ class CPDF_FormField { FX_BOOL bDefault, FX_BOOL bNotify); + CPDF_FormField::Type m_Type; + FX_DWORD m_Flags; + CPDF_InterForm* m_pForm; + CPDF_Dictionary* m_pDict; + CFX_ArrayTemplate m_ControlList; FX_FLOAT m_FontSize; - CPDF_Font* m_pFont; + + friend class CPDF_InterForm; + friend class CPDF_FormControl; }; CPDF_Object* FPDF_GetFieldAttr(CPDF_Dictionary* pFieldDict, const FX_CHAR* name, -- cgit v1.2.3