From 85d5c4af4a9546970b34dd413c473d10fef8534b Mon Sep 17 00:00:00 2001 From: Tom Sepez Date: Tue, 18 Aug 2015 09:20:29 -0700 Subject: FX_CMapDwordToDword considered harmful. Lookups are log(n), but random insertions could result in n^2 behaviour. Replace with maps and sets. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1289703003 . --- core/include/fxcrt/fx_basic.h | 15 --------------- 1 file changed, 15 deletions(-) (limited to 'core/include/fxcrt/fx_basic.h') diff --git a/core/include/fxcrt/fx_basic.h b/core/include/fxcrt/fx_basic.h index 230d3db0f0..bc3d81200f 100644 --- a/core/include/fxcrt/fx_basic.h +++ b/core/include/fxcrt/fx_basic.h @@ -635,21 +635,6 @@ class CFX_MapPtrToPtr { CAssoc* GetAssocAt(void* key, FX_DWORD& hash) const; }; -class CFX_CMapDWordToDWord { - public: - FX_BOOL Lookup(FX_DWORD key, FX_DWORD& value) const; - - void SetAt(FX_DWORD key, FX_DWORD value); - - void EstimateSize(FX_DWORD size, FX_DWORD grow_by); - - FX_POSITION GetStartPosition() const; - - void GetNextAssoc(FX_POSITION& pos, FX_DWORD& key, FX_DWORD& value) const; - - protected: - CFX_BinaryBuf m_Buffer; -}; class CFX_CMapByteStringToPtr { public: CFX_CMapByteStringToPtr(); -- cgit v1.2.3