From ffc26c26f0ab004fbdb05195e1686d7f33983b06 Mon Sep 17 00:00:00 2001
From: Tom Sepez <tsepez@chromium.org>
Date: Fri, 19 Feb 2016 14:28:12 -0800
Subject: Revert "Use safe arithmentic in CFX_BinaryBuf::ExpandBuf."

This reverts commit 78353d5dbc0b0c9b2d6946005439a51efa7d108c.
Reason for revert Failed tests.

TBR=thestig@chromium.org

Review URL: https://codereview.chromium.org/1719493002 .
---
 core/include/fxcrt/fx_basic.h | 110 ++++++++++++++++++++++++++----------------
 1 file changed, 69 insertions(+), 41 deletions(-)

(limited to 'core/include/fxcrt/fx_basic.h')

diff --git a/core/include/fxcrt/fx_basic.h b/core/include/fxcrt/fx_basic.h
index 3e30b1d1a1..de915323d0 100644
--- a/core/include/fxcrt/fx_basic.h
+++ b/core/include/fxcrt/fx_basic.h
@@ -8,7 +8,6 @@
 #define CORE_INCLUDE_FXCRT_FX_BASIC_H_
 
 #include <algorithm>
-#include <memory>
 
 #include "core/include/fxcrt/fx_memory.h"
 #include "core/include/fxcrt/fx_stream.h"
@@ -30,90 +29,109 @@
 template <typename T, size_t N>
 char(&ArraySizeHelper(T(&array)[N]))[N];
 
-// Used with std::unique_ptr to FX_Free raw memory.
-struct FxFreeDeleter {
-  inline void operator()(void* ptr) const { FX_Free(ptr); }
-};
-
-// Used with std::unique_ptr to Release() objects that can't be deleted.
-template <class T>
-struct ReleaseDeleter {
-  inline void operator()(T* ptr) const { ptr->Release(); }
-};
-
 class CFX_BinaryBuf {
  public:
   CFX_BinaryBuf();
-  explicit CFX_BinaryBuf(FX_STRSIZE size);
+  CFX_BinaryBuf(FX_STRSIZE size);
 
-  uint8_t* GetBuffer() const { return m_pBuffer.get(); }
-  FX_STRSIZE GetSize() const { return m_DataSize; }
+  ~CFX_BinaryBuf();
 
   void Clear();
+
   void EstimateSize(FX_STRSIZE size, FX_STRSIZE alloc_step = 0);
+
   void AppendBlock(const void* pBuf, FX_STRSIZE size);
+
+  void AppendFill(uint8_t byte, FX_STRSIZE count);
+
   void AppendString(const CFX_ByteStringC& str) {
     AppendBlock(str.GetPtr(), str.GetLength());
   }
 
-  void AppendByte(uint8_t byte) {
-    ExpandBuf(1);
-    m_pBuffer.get()[m_DataSize++] = byte;
+  inline void AppendByte(uint8_t byte) {
+    if (m_AllocSize <= m_DataSize) {
+      ExpandBuf(1);
+    }
+    m_pBuffer[m_DataSize++] = byte;
   }
 
   void InsertBlock(FX_STRSIZE pos, const void* pBuf, FX_STRSIZE size);
+
+  void AttachData(void* pBuf, FX_STRSIZE size);
+
+  void CopyData(const void* pBuf, FX_STRSIZE size);
+
+  void TakeOver(CFX_BinaryBuf& other);
+
   void Delete(int start_index, int count);
 
-  // Takes ownership of |pBuf|.
-  void AttachData(uint8_t* pBuf, FX_STRSIZE size);
+  uint8_t* GetBuffer() const { return m_pBuffer; }
 
-  // Releases ownership of |m_pBuffer| and returns it.
-  uint8_t* DetachBuffer();
+  FX_STRSIZE GetSize() const { return m_DataSize; }
 
- protected:
-  void ExpandBuf(FX_STRSIZE size);
+  CFX_ByteStringC GetByteString() const;
+
+  void DetachBuffer();
 
+ protected:
   FX_STRSIZE m_AllocStep;
-  FX_STRSIZE m_AllocSize;
+
+  uint8_t* m_pBuffer;
+
   FX_STRSIZE m_DataSize;
-  std::unique_ptr<uint8_t, FxFreeDeleter> m_pBuffer;
-};
 
+  FX_STRSIZE m_AllocSize;
+
+  void ExpandBuf(FX_STRSIZE size);
+};
 class CFX_ByteTextBuf : public CFX_BinaryBuf {
  public:
+  void operator=(const CFX_ByteStringC& str);
+
   void AppendChar(int ch) { AppendByte((uint8_t)ch); }
-  FX_STRSIZE GetLength() const { return m_DataSize; }
-  CFX_ByteStringC GetByteString() const;
 
   CFX_ByteTextBuf& operator<<(int i);
+
   CFX_ByteTextBuf& operator<<(FX_DWORD i);
+
   CFX_ByteTextBuf& operator<<(double f);
+
   CFX_ByteTextBuf& operator<<(const CFX_ByteStringC& lpsz);
+
   CFX_ByteTextBuf& operator<<(const CFX_ByteTextBuf& buf);
-};
 
+  FX_STRSIZE GetLength() const { return m_DataSize; }
+};
 class CFX_WideTextBuf : public CFX_BinaryBuf {
  public:
-  void AppendChar(FX_WCHAR wch);
-  FX_STRSIZE GetLength() const { return m_DataSize / sizeof(FX_WCHAR); }
-  FX_WCHAR* GetBuffer() const {
-    return reinterpret_cast<FX_WCHAR*>(m_pBuffer.get());
-  }
-  CFX_WideStringC GetWideString() const;
+  void operator=(const FX_WCHAR* lpsz);
 
-  void Delete(int start_index, int count) {
-    CFX_BinaryBuf::Delete(start_index * sizeof(FX_WCHAR),
-                          count * sizeof(FX_WCHAR));
-  }
+  void operator=(const CFX_WideStringC& str);
+
+  void AppendChar(FX_WCHAR wch);
 
   CFX_WideTextBuf& operator<<(int i);
+
   CFX_WideTextBuf& operator<<(double f);
+
   CFX_WideTextBuf& operator<<(const FX_WCHAR* lpsz);
+
   CFX_WideTextBuf& operator<<(const CFX_WideStringC& str);
   CFX_WideTextBuf& operator<<(const CFX_WideString& str);
+
   CFX_WideTextBuf& operator<<(const CFX_WideTextBuf& buf);
-};
 
+  FX_STRSIZE GetLength() const { return m_DataSize / sizeof(FX_WCHAR); }
+
+  FX_WCHAR* GetBuffer() const { return (FX_WCHAR*)m_pBuffer; }
+
+  void Delete(int start_index, int count) {
+    CFX_BinaryBuf::Delete(start_index * sizeof(FX_WCHAR),
+                          count * sizeof(FX_WCHAR));
+  }
+
+  CFX_WideStringC GetWideString() const;
+};
 #ifdef PDF_ENABLE_XFA
 class CFX_ArchiveSaver {
  public:
@@ -1013,6 +1031,16 @@ class CFX_AutoRestorer {
   const T m_OldValue;
 };
 
+struct FxFreeDeleter {
+  inline void operator()(void* ptr) const { FX_Free(ptr); }
+};
+
+// Used with std::unique_ptr to Release() objects that can't be deleted.
+template <class T>
+struct ReleaseDeleter {
+  inline void operator()(T* ptr) const { ptr->Release(); }
+};
+
 #define FX_DATALIST_LENGTH 1024
 template <size_t unit>
 class CFX_SortListArray {
-- 
cgit v1.2.3