From 0185408126529d5df7e095c5789affd4ae971375 Mon Sep 17 00:00:00 2001 From: Bo Xu Date: Wed, 21 Jan 2015 12:17:23 -0800 Subject: Simplify UTF16LE_Encode and add unittest. Previously, UTF16LE_Encode take an optional flag to indicate if the returned byte string has trailing zeros. In fact, no where needs the flag to be false. So just get rid of it so callers won't misuse. The bug is found by https://codereview.chromium.org/837723009 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/860973002 --- core/include/fxcrt/fx_string.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'core/include') diff --git a/core/include/fxcrt/fx_string.h b/core/include/fxcrt/fx_string.h index eae1c15a04..33634f8379 100644 --- a/core/include/fxcrt/fx_string.h +++ b/core/include/fxcrt/fx_string.h @@ -774,7 +774,7 @@ public: CFX_ByteString UTF8Encode() const; - CFX_ByteString UTF16LE_Encode(FX_BOOL bTerminate = TRUE) const; + CFX_ByteString UTF16LE_Encode() const; void ConvertFrom(const CFX_ByteString& str, CFX_CharMap* pCharMap = NULL); protected: -- cgit v1.2.3