From 468974316ed5f6b6f8e637ab2c7afedc7c2bfe6a Mon Sep 17 00:00:00 2001 From: Dan Sinclair Date: Tue, 27 Oct 2015 13:18:28 -0400 Subject: Give names to the shading types Currently the shading types are referenced by number. This Cl creates and enum and updates the code to use the enum names instead of magic numbers. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1418623011 . --- core/include/fpdfapi/fpdf_resource.h | 22 +++++++++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-) (limited to 'core/include') diff --git a/core/include/fpdfapi/fpdf_resource.h b/core/include/fpdfapi/fpdf_resource.h index 9fe6e2b95f..dee15cf941 100644 --- a/core/include/fpdfapi/fpdf_resource.h +++ b/core/include/fpdfapi/fpdf_resource.h @@ -679,6 +679,19 @@ class CPDF_TilingPattern : public CPDF_Pattern { CPDF_Form* m_pForm; }; + +typedef enum { + kInvalidShading = 0, + kFunctionBasedShading = 1, + kAxialShading = 2, + kRadialShading = 3, + kFreeFormGouraudTriangleMeshShading = 4, + kLatticeFormGouraudTriangleMeshShading = 5, + kCoonsPatchMeshShading = 6, + kTensorProductPatchMeshShading = 7, + kMaxShading = 8 +} ShadingType; + class CPDF_ShadingPattern : public CPDF_Pattern { public: CPDF_ShadingPattern(CPDF_Document* pDoc, @@ -688,6 +701,13 @@ class CPDF_ShadingPattern : public CPDF_Pattern { ~CPDF_ShadingPattern() override; + bool IsMeshShading() const { + return m_ShadingType == kFreeFormGouraudTriangleMeshShading || + m_ShadingType == kLatticeFormGouraudTriangleMeshShading || + m_ShadingType == kCoonsPatchMeshShading || + m_ShadingType == kTensorProductPatchMeshShading; + } + CPDF_Object* m_pShadingObj; FX_BOOL m_bShadingObj; @@ -696,7 +716,7 @@ class CPDF_ShadingPattern : public CPDF_Pattern { FX_BOOL Reload(); - int m_ShadingType; + ShadingType m_ShadingType; CPDF_ColorSpace* m_pCS; // Still keep m_pCS as some CPDF_ColorSpace (name // object) are not managed as counted objects. Refer -- cgit v1.2.3