From 786febb9c8e85b9215a6a5126c6386a9f4b4d280 Mon Sep 17 00:00:00 2001 From: Lei Zhang Date: Wed, 17 Dec 2014 16:54:04 -0800 Subject: XFA: merge patch from CL 790213005 Cleanup: Pass by const reference in fpdftext. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/790213005 --- core/include/fpdftext/fpdf_text.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'core/include') diff --git a/core/include/fpdftext/fpdf_text.h b/core/include/fpdftext/fpdf_text.h index 2a5e4ac4bd..39008063f3 100644 --- a/core/include/fpdftext/fpdf_text.h +++ b/core/include/fpdftext/fpdf_text.h @@ -105,9 +105,9 @@ public: virtual int GetOrderByDirection(int index, int direction) const = 0; - virtual CFX_WideString GetTextByRect(CFX_FloatRect rect) const = 0; + virtual CFX_WideString GetTextByRect(const CFX_FloatRect& rect) const = 0; - virtual void GetRectsArrayByRect(CFX_FloatRect rect, CFX_RectArray& resRectArray) const = 0; + virtual void GetRectsArrayByRect(const CFX_FloatRect& rect, CFX_RectArray& resRectArray) const = 0; virtual int CountRects(int start, int nCount) = 0; @@ -116,7 +116,7 @@ public: virtual FX_BOOL GetBaselineRotate(int rectIndex, int& Rotate) = 0; - virtual FX_BOOL GetBaselineRotate(CFX_FloatRect rect, int& Rotate) = 0; + virtual FX_BOOL GetBaselineRotate(const CFX_FloatRect& rect, int& Rotate) = 0; virtual int CountBoundedSegments(FX_FLOAT left, FX_FLOAT top, FX_FLOAT right, FX_FLOAT bottom, FX_BOOL bContains = FALSE) = 0; @@ -139,7 +139,7 @@ public: static IPDF_TextPageFind* CreatePageFind(const IPDF_TextPage* pTextPage); public: - virtual FX_BOOL FindFirst(CFX_WideString findwhat, int flags, int startPos = 0) = 0; + virtual FX_BOOL FindFirst(const CFX_WideString& findwhat, int flags, int startPos = 0) = 0; virtual FX_BOOL FindNext() = 0; -- cgit v1.2.3