From 68ee086a1f61dd9a886c96dae8d30de7c9d535fb Mon Sep 17 00:00:00 2001 From: Tom Sepez Date: Thu, 5 Feb 2015 17:33:27 -0800 Subject: Kill off some more unreachable fopen's. The bstring's read from file is unused. The load from file paths aren't taken. R=jam@chromium.org Review URL: https://codereview.chromium.org/902943003 --- core/src/fpdfapi/fpdf_font/fpdf_font_cid.cpp | 77 ++-------------------------- 1 file changed, 3 insertions(+), 74 deletions(-) (limited to 'core/src/fpdfapi/fpdf_font/fpdf_font_cid.cpp') diff --git a/core/src/fpdfapi/fpdf_font/fpdf_font_cid.cpp b/core/src/fpdfapi/fpdf_font/fpdf_font_cid.cpp index 766fd352b4..cbfa19d084 100644 --- a/core/src/fpdfapi/fpdf_font/fpdf_font_cid.cpp +++ b/core/src/fpdfapi/fpdf_font/fpdf_font_cid.cpp @@ -11,28 +11,17 @@ #include "../../../include/fxge/fx_ge.h" #include "../../../include/fxge/fx_freetype.h" extern FX_DWORD FT_CharCodeFromUnicode(int encoding, FX_WCHAR unicode); -extern FX_LPVOID FXFC_LoadPackage(FX_LPCSTR name); -extern FX_BOOL FXFC_LoadFile(FX_LPVOID pPackage, FX_LPCSTR name, FX_LPBYTE& pBuffer, FX_DWORD& size); -extern void FXFC_ClosePackage(FX_LPVOID pPackage); extern short TT2PDF(int m, FXFT_Face face); extern FX_BOOL FT_UseTTCharmap(FXFT_Face face, int platform_id, int encoding_id); extern FX_LPCSTR GetAdobeCharName(int iBaseEncoding, const CFX_ByteString* pCharNames, int charcode); CPDF_CMapManager::CPDF_CMapManager() { m_bPrompted = FALSE; - m_pPackage = NULL; FXSYS_memset32(m_CID2UnicodeMaps, 0, sizeof m_CID2UnicodeMaps); } CPDF_CMapManager::~CPDF_CMapManager() { DropAll(FALSE); - if (m_pPackage) { - FXFC_ClosePackage(m_pPackage); - } -} -FX_LPVOID CPDF_CMapManager::GetPackage(FX_BOOL bPrompt) -{ - return m_pPackage; } CPDF_CMap* CPDF_CMapManager::GetPredefinedCMap(const CFX_ByteString& name, FX_BOOL bPromptCJK) { @@ -399,50 +388,7 @@ FX_BOOL CPDF_CMap::LoadPredefined(CPDF_CMapManager* pMgr, FX_LPCSTR pName, FX_BO m_bLoaded = TRUE; return TRUE; } - FX_LPVOID pPackage = pMgr->GetPackage(bPromptCJK); - FX_LPBYTE pBuffer; - FX_DWORD size; - if (pPackage == NULL || !FXFC_LoadFile(pPackage, m_PredefinedCMap, pBuffer, size)) { - return FALSE; - } - m_pMapping = FX_Alloc(FX_WORD, 65536); - FX_DWORD dwRecodeEndPos = 0; - if (pBuffer[5] == 0) { - FX_DWORD dwStartIndex = *(FX_DWORD*)(pBuffer + 8); - FX_DWORD dwRecordCount = *(FX_DWORD*)(pBuffer + 16); - FX_DWORD dwDataOffset = *(FX_DWORD*)(pBuffer + 20); - if (dwRecordCount * 2 + dwStartIndex * 2 < 65536) { - FXSYS_memcpy32(m_pMapping + dwStartIndex * 2, pBuffer + dwDataOffset, dwRecordCount * 2); - } - dwRecodeEndPos = dwDataOffset + dwRecordCount * 2; - } else if (pBuffer[5] == 2) { - FX_DWORD nSegments = *(FX_DWORD*)(pBuffer + 16); - FX_DWORD dwDataOffset = *(FX_DWORD*)(pBuffer + 20); - dwRecodeEndPos = dwDataOffset + 6 * nSegments; - for (FX_DWORD i = 0; i < nSegments; i ++) { - FX_LPBYTE pRecord = pBuffer + dwDataOffset + i * 6; - FX_WORD IndexStart = *(FX_WORD*)pRecord; - FX_WORD IndexCount = *(FX_WORD*)(pRecord + 2); - FX_WORD CodeStart = *(FX_WORD*)(pRecord + 4); - if (IndexStart + IndexCount < 65536) - for (FX_DWORD j = 0; j < IndexCount; j ++) { - m_pMapping[IndexStart + j ] = (FX_WORD)(CodeStart + j); - } - } - } - if (dwRecodeEndPos < size) { - FX_DWORD dwMapLen = *(FX_DWORD*)(pBuffer + dwRecodeEndPos); - if (dwMapLen) { - m_pUseMap = FX_NEW CPDF_CMap; - CFX_ByteString bsName(pBuffer + dwRecodeEndPos + 4 , dwMapLen); - if (m_pUseMap) { - m_pUseMap->LoadPredefined(pMgr, bsName, bPromptCJK); - } - } - } - FX_Free(pBuffer); - m_bLoaded = TRUE; - return TRUE; + return FALSE; } extern "C" { static int compare_dword(const void* data1, const void* data2) @@ -718,22 +664,17 @@ int CPDF_CMap::AppendChar(FX_LPSTR str, FX_DWORD charcode) const CPDF_CID2UnicodeMap::CPDF_CID2UnicodeMap() { m_EmbeddedCount = 0; - m_pExternalMap = NULL; } CPDF_CID2UnicodeMap::~CPDF_CID2UnicodeMap() { - if (m_pExternalMap) { - delete m_pExternalMap; - } } FX_BOOL CPDF_CID2UnicodeMap::Initialize() { - m_pExternalMap = FX_NEW CPDF_FXMP; return TRUE; } FX_BOOL CPDF_CID2UnicodeMap::IsLoaded() { - return m_EmbeddedCount != 0 || (m_pExternalMap != NULL && m_pExternalMap->IsLoaded()); + return m_EmbeddedCount != 0; } FX_WCHAR CPDF_CID2UnicodeMap::UnicodeFromCID(FX_WORD CID) { @@ -743,25 +684,13 @@ FX_WCHAR CPDF_CID2UnicodeMap::UnicodeFromCID(FX_WORD CID) if (CID < m_EmbeddedCount) { return m_pEmbeddedMap[CID]; } - FX_LPCBYTE record = m_pExternalMap->GetRecord(CID); - if (record == NULL) { - return 0; - } - return *(FX_WORD*)record; + return 0; } void FPDFAPI_LoadCID2UnicodeMap(int charset, const FX_WORD*& pMap, FX_DWORD& count); void CPDF_CID2UnicodeMap::Load(CPDF_CMapManager* pMgr, int charset, FX_BOOL bPromptCJK) { m_Charset = charset; FPDFAPI_LoadCID2UnicodeMap(charset, m_pEmbeddedMap, m_EmbeddedCount); - if (m_EmbeddedCount) { - return; - } - FX_LPVOID pPackage = pMgr->GetPackage(bPromptCJK); - if (pPackage == NULL) { - return; - } - m_pExternalMap->LoadFile(pPackage, FX_BSTRC("CIDInfo_") + g_CharsetNames[charset]); } #include "ttgsubtable.h" CPDF_CIDFont::CPDF_CIDFont() -- cgit v1.2.3