From cb62e7657b3a9a04142028a4e6614029a08e894b Mon Sep 17 00:00:00 2001 From: Lei Zhang Date: Fri, 14 Aug 2015 15:45:39 -0700 Subject: Don't bother checking pointers before delete[] and FX_Free(). R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1297713003 . --- core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) (limited to 'core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp') diff --git a/core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp b/core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp index 47ba46a0f3..059dd4c2a6 100644 --- a/core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp +++ b/core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp @@ -83,9 +83,7 @@ CPDF_StreamContentParser::~CPDF_StreamContentParser() { for (int i = 0; i < m_StateStack.GetSize(); ++i) { delete (CPDF_AllStates*)m_StateStack[i]; } - if (m_pPathPoints) { - FX_Free(m_pPathPoints); - } + FX_Free(m_pPathPoints); if (m_pLastImageDict) { m_pLastImageDict->Release(); } @@ -1087,9 +1085,7 @@ void CPDF_StreamContentParser::Handle_SetColorPS_Fill() { } else { m_pCurStates->m_ColorState.SetFillColor(NULL, values, nvalues); } - if (values) { - FX_Free(values); - } + FX_Free(values); } void CPDF_StreamContentParser::Handle_SetColorPS_Stroke() { if (m_Options.m_bTextOnly) { @@ -1119,9 +1115,7 @@ void CPDF_StreamContentParser::Handle_SetColorPS_Stroke() { } else { m_pCurStates->m_ColorState.SetStrokeColor(NULL, values, nvalues); } - if (values) { - FX_Free(values); - } + FX_Free(values); } CFX_FloatRect _GetShadingBBox(CPDF_Stream* pStream, int type, -- cgit v1.2.3