From c998e22d3bb0c9ce035aea2e9fe9e39a3f14fe3c Mon Sep 17 00:00:00 2001 From: Qin Zhao Date: Wed, 25 Nov 2015 10:52:35 -0500 Subject: Merge to XFA: Fix two memory leaks from pdfium_unittests - remove redundant alloc in fx_codec_jpx_unittest.cpp - free memory allocated by HexDecode calls in fpdf_parser_decode_unittest.cpp BUG=PDFium:239 R=thestig@chromium.org Review URL: https://codereview.chromium.org/1467183006 . (cherry picked from commit 6c2d736011c09266015d3e2a0b9c08aeba1bbf31) Review URL: https://codereview.chromium.org/1477833002 . --- core/src/fpdfapi/fpdf_parser/fpdf_parser_decode_unittest.cpp | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'core/src/fpdfapi/fpdf_parser') diff --git a/core/src/fpdfapi/fpdf_parser/fpdf_parser_decode_unittest.cpp b/core/src/fpdfapi/fpdf_parser/fpdf_parser_decode_unittest.cpp index 95d7c84ace..3318bcdfe7 100644 --- a/core/src/fpdfapi/fpdf_parser/fpdf_parser_decode_unittest.cpp +++ b/core/src/fpdfapi/fpdf_parser/fpdf_parser_decode_unittest.cpp @@ -14,6 +14,7 @@ TEST(fpdf_parser_decode, HexDecode) { EXPECT_EQ(0, HexDecode(src, 0, dest, dest_size)); EXPECT_EQ(0, dest_size); EXPECT_EQ('\0', dest[0]); + FX_Free(dest); } { @@ -25,6 +26,7 @@ TEST(fpdf_parser_decode, HexDecode) { EXPECT_EQ(2, dest_size); EXPECT_EQ(18, dest[0]); EXPECT_EQ(172, dest[1]); + FX_Free(dest); } { @@ -36,6 +38,7 @@ TEST(fpdf_parser_decode, HexDecode) { EXPECT_EQ(2, dest_size); EXPECT_EQ(18, dest[0]); EXPECT_EQ(160, dest[1]); + FX_Free(dest); } { @@ -47,5 +50,6 @@ TEST(fpdf_parser_decode, HexDecode) { EXPECT_EQ(2, dest_size); EXPECT_EQ(18, dest[0]); EXPECT_EQ(172, dest[1]); + FX_Free(dest); } } -- cgit v1.2.3