From c5fd3e95fbc42f41479f803e4f2f0b4a7c4fc612 Mon Sep 17 00:00:00 2001
From: Dan Sinclair <dsinclair@chromium.org>
Date: Tue, 27 Oct 2015 13:24:54 -0400
Subject: Merge to XFA: Give names to the shading types

Currently the shading types are referenced by number. This Cl creates and enum
and updates the code to use the enum names instead of magic numbers.

R=tsepez@chromium.org

Review URL: https://codereview.chromium.org/1418623011 .

(cherry picked from commit 468974316ed5f6b6f8e637ab2c7afedc7c2bfe6a)

Review URL: https://codereview.chromium.org/1428573002 .
---
 .../fpdfapi/fpdf_render/fpdf_render_pattern.cpp    | 24 +++++++++++++---------
 1 file changed, 14 insertions(+), 10 deletions(-)

(limited to 'core/src/fpdfapi/fpdf_render')

diff --git a/core/src/fpdfapi/fpdf_render/fpdf_render_pattern.cpp b/core/src/fpdfapi/fpdf_render/fpdf_render_pattern.cpp
index 4ed6c07675..467ffc900c 100644
--- a/core/src/fpdfapi/fpdf_render/fpdf_render_pattern.cpp
+++ b/core/src/fpdfapi/fpdf_render/fpdf_render_pattern.cpp
@@ -868,33 +868,37 @@ void CPDF_RenderStatus::DrawShading(CPDF_ShadingPattern* pPattern,
   pBitmap->Clear(background);
   int fill_mode = m_Options.m_Flags;
   switch (pPattern->m_ShadingType) {
-    case 1:
+    case kInvalidShading:
+    case kMaxShading:
+      return;
+    case kFunctionBasedShading:
       DrawFuncShading(pBitmap, &FinalMatrix, pDict, pFuncs, nFuncs, pColorSpace,
                       alpha);
       break;
-    case 2:
+    case kAxialShading:
       DrawAxialShading(pBitmap, &FinalMatrix, pDict, pFuncs, nFuncs,
                        pColorSpace, alpha);
       break;
-    case 3:
+    case kRadialShading:
       DrawRadialShading(pBitmap, &FinalMatrix, pDict, pFuncs, nFuncs,
                         pColorSpace, alpha);
       break;
-    case 4: {
+    case kFreeFormGouraudTriangleMeshShading: {
       DrawFreeGouraudShading(pBitmap, &FinalMatrix,
                              ToStream(pPattern->m_pShadingObj), pFuncs, nFuncs,
                              pColorSpace, alpha);
     } break;
-    case 5: {
+    case kLatticeFormGouraudTriangleMeshShading: {
       DrawLatticeGouraudShading(pBitmap, &FinalMatrix,
                                 ToStream(pPattern->m_pShadingObj), pFuncs,
                                 nFuncs, pColorSpace, alpha);
     } break;
-    case 6:
-    case 7: {
-      DrawCoonPatchMeshes(pPattern->m_ShadingType - 6, pBitmap, &FinalMatrix,
-                          ToStream(pPattern->m_pShadingObj), pFuncs, nFuncs,
-                          pColorSpace, fill_mode, alpha);
+    case kCoonsPatchMeshShading:
+    case kTensorProductPatchMeshShading: {
+      DrawCoonPatchMeshes(
+          pPattern->m_ShadingType == kTensorProductPatchMeshShading, pBitmap,
+          &FinalMatrix, ToStream(pPattern->m_pShadingObj), pFuncs, nFuncs,
+          pColorSpace, fill_mode, alpha);
     } break;
   }
   if (bAlphaMode) {
-- 
cgit v1.2.3