From ee7412f5aef353e5c6f1a64d0e1708ed926869d9 Mon Sep 17 00:00:00 2001 From: Tom Sepez Date: Mon, 27 Apr 2015 15:00:04 -0700 Subject: Make CFX_WideString::LockBuffer() completely unused. Then remove CFX_{Wide,Byte}String::LockBuffer(). Prelude to a vast simplification. There's an additional copy now in one place, so shoot me. BUG=pdfium:144 R=thestig@chromium.org Review URL: https://codereview.chromium.org/1053613004 --- core/src/fpdfdoc/doc_bookmark.cpp | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) (limited to 'core/src/fpdfdoc/doc_bookmark.cpp') diff --git a/core/src/fpdfdoc/doc_bookmark.cpp b/core/src/fpdfdoc/doc_bookmark.cpp index 9814de61bf..88dcf21be1 100644 --- a/core/src/fpdfdoc/doc_bookmark.cpp +++ b/core/src/fpdfdoc/doc_bookmark.cpp @@ -55,15 +55,13 @@ CFX_WideString CPDF_Bookmark::GetTitle() const return CFX_WideString(); } CFX_WideString title = pString->GetUnicodeText(); - FX_LPWSTR buf = title.LockBuffer(); int len = title.GetLength(); + FX_WCHAR buf[len]; for (int i = 0; i < len; i++) { - if (buf[i] < 0x20) { - buf[i] = 0x20; - } + FX_WCHAR w = title[i]; + buf[i] = w > 0x20 ? w : 0x20; } - title.ReleaseBuffer(len); - return title; + return CFX_WideString(buf, len); } CPDF_Dest CPDF_Bookmark::GetDest(CPDF_Document* pDocument) const { -- cgit v1.2.3