From 7b2897c47245f04c806cfa8cee09458e31ba3777 Mon Sep 17 00:00:00 2001 From: Lei Zhang Date: Wed, 10 Jun 2015 13:29:24 -0700 Subject: Cache the CPDF_Annot's subtype, since it should never changes. BUG=495300 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1178513002. --- core/src/fpdfdoc/doc_annot.cpp | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) (limited to 'core/src/fpdfdoc') diff --git a/core/src/fpdfdoc/doc_annot.cpp b/core/src/fpdfdoc/doc_annot.cpp index 3fe20b6e28..e9084ba26e 100644 --- a/core/src/fpdfdoc/doc_annot.cpp +++ b/core/src/fpdfdoc/doc_annot.cpp @@ -135,8 +135,9 @@ int CPDF_AnnotList::GetIndex(CPDF_Annot* pAnnot) return -1; } CPDF_Annot::CPDF_Annot(CPDF_Dictionary* pDict, CPDF_AnnotList* pList) - : m_pAnnotDict(pDict), - m_pList(pList) + : m_pAnnotDict(pDict), + m_pList(pList), + m_sSubtype(m_pAnnotDict->GetConstString(FX_BSTRC("Subtype"))) { } CPDF_Annot::~CPDF_Annot() @@ -156,7 +157,7 @@ void CPDF_Annot::ClearCachedAP() } CFX_ByteString CPDF_Annot::GetSubType() const { - return m_pAnnotDict ? m_pAnnotDict->GetConstString(FX_BSTRC("Subtype")) : CFX_ByteStringC(); + return m_sSubtype; } void CPDF_Annot::GetRect(CPDF_Rect& rect) const -- cgit v1.2.3