From 4db62f5d942a3a7be00bfb5711836ce9e2c89f4b Mon Sep 17 00:00:00 2001 From: John Abd-El-Malek Date: Tue, 20 May 2014 14:34:30 -0700 Subject: Fixed or silenced all warnings and turned on warnings-as-errors. - Silence -Wheader-hygiene warning on Clang. Between fx_agg_driver.cpp and fxjs_v8.h there are hundreds or thousands of things that depend on "using namespace", so it is best to just suppress this warning than fix it. - gzguts.h: Include unistd.h on all non-Windows platforms, not just Apple platforms. Fixes implicit include warnings on Linux. - Added parens to silence a warning about mixing && and ||. - Removed a check if an enum is negative. Enums can be unsigned, generating an always-false warning. The check isn't necessary. - Removed some statements that are just names of variables that do nothing. BUG=375114 Patch by Matt Giuca --- core/src/fxcodec/lcms2/lcms2-2.6/src/cmsplugin.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'core/src/fxcodec/lcms2/lcms2-2.6') diff --git a/core/src/fxcodec/lcms2/lcms2-2.6/src/cmsplugin.c b/core/src/fxcodec/lcms2/lcms2-2.6/src/cmsplugin.c index 55928b7018..8903d2bd61 100644 --- a/core/src/fxcodec/lcms2/lcms2-2.6/src/cmsplugin.c +++ b/core/src/fxcodec/lcms2/lcms2-2.6/src/cmsplugin.c @@ -689,7 +689,7 @@ void* _cmsContextGetClientChunk(cmsContext ContextID, _cmsMemoryClient mc) struct _cmsContext_struct* ctx; void *ptr; - if (mc < 0 || mc >= MemoryClientMax) { + if (mc >= MemoryClientMax) { cmsSignalError(ContextID, cmsERROR_RANGE, "Bad context client"); return NULL; } -- cgit v1.2.3